[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Libunwind-devel] WIP patch: configurable cache size
|
From: |
Arun Sharma |
|
Subject: |
Re: [Libunwind-devel] WIP patch: configurable cache size |
|
Date: |
Mon, 22 Dec 2014 22:39:29 +0530 |
On Thu, Dec 11, 2014 at 7:12 PM, Milian Wolff <address@hidden> wrote:
> On Thursday 11 December 2014 13:58:14 Milian Wolff wrote:
>> Hey Arun,
>>
>> I'm still waiting for your mail you promised below ;-) Locally, I've rebased
>> my patch on current master.
>
> FTR, attached you find the current state of my patch. Anything missing/wrong,
> besides documentation?
>
> -#define DWARF_LOG_UNW_CACHE_SIZE 7
Why not retain DWARF_LOG_UNW_CACHE_SIZE and use it in a few places
that use the constant 7?
The rest of the code looks alright to me. Could you look into the make
check failures introduced by the patch? I got 5 new failures.
-Arun