[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Libunwind-devel] [PATCH] [MIPS] Stack-unwinding through signal fram
|
From: |
Arun Sharma |
|
Subject: |
Re: [Libunwind-devel] [PATCH] [MIPS] Stack-unwinding through signal frames |
|
Date: |
Thu, 2 Apr 2015 23:51:45 +0530 |
Applied with minor whitespace fixup. Thanks!
-Arun
On Wed, Apr 1, 2015 at 11:39 PM, Faraz Shahbazker
<address@hidden> wrote:
> On 03/19/2015 09:19 PM, Arun Sharma wrote:
>> On Thu, Mar 19, 2015 at 9:52 AM, Faraz Shahbazker
>> <address@hidden> wrote:
>>
>>>> Assumes your libc has the .cfi_signal_frame annotations in the right
>>>> places.
>>>
>>> Okay, looks like its not available for MIPS.
>>
>> You mean widely deployed libcs for MIPS don't have the
>> .cfi_signal_frame annotation?
>>
>> I'm ok with applying your patches for now. But could you please work
>> with the upstream maintainers to add the annotation, so we can revert
>> this code when the annotation is widely deployed?
>
> I will do that, but it would be good to get this patch in just to get MIPS
> support in libunwind on terms with what other architectures are doing
> vis-a-vis signal-frame detection. As far as I can make out, x86_64 is the
> only arch that uses CIE augmentation strings, all other architectures rely on
> checking preceding instructions.
>
> Regards,
> Faraz Shahbazker