[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Libunwind-devel] [PATCH] [RFC] add fallback logic for coredump regi
From: |
Dave Watson |
Subject: |
Re: [Libunwind-devel] [PATCH] [RFC] add fallback logic for coredump register access |
Date: |
Wed, 15 Feb 2017 14:41:39 -0800 |
User-agent: |
Mutt/1.6.0 (2016-04-01) |
On 02/14/17 01:22 PM, Mike Frysinger wrote:
> Caveat: I haven't spent time looking into the libunwind API and seeing
> if these arches need their own mapping, or if they have more registers
> in the coredump than libunwind exposes.
>
> At least it no longer fails to compile? :)
> ---
> +#elif defined(UNW_TARGET_IA64) || defined(UNW_TARGET_HPPA) ||
> defined(UNW_TARGET_PPC32) || defined(UNW_TARGET_PPC64)
> + if (regnum >= ARRAY_SIZE(ui->prstatus->pr_reg))
> + goto badreg;
Are you able to test any of these arches ? :) The travis build for
ppc is currently off because of other issues, and I don't think it
have support for the other two.
I suspect all of these have other lingering issues, and we should just
let it be unless someone wants to dive in and spend more time on them.