[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Libunwind-devel] [patch] fetch16 and fetch32 should not assert
|
From: |
Dave Watson |
|
Subject: |
Re: [Libunwind-devel] [patch] fetch16 and fetch32 should not assert |
|
Date: |
Wed, 5 Apr 2017 11:23:44 -0700 |
|
User-agent: |
Mutt/1.6.0 (2016-04-01) |
On 04/04/17 06:16 PM, Paul Pluzhnikov wrote:
> Greetings,
>
> In src/ppc64/Gstep.c, we use fetch32 to fetch instruction from the
> inferior process. In UNW_REMOTE case, fetch32 asserts that the
> address we are fetching from is aligned.
>
> But if the inferior is corrupt, we can get unaligned IP, and hit the assert.
>
> Attached patch removes the assert, and makes fetch32 (and fetch16)
> return -UNW_EINVAL instead.
Merged, thanks.