[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Libunwind-devel] typo bug for arm in _UPT_find_proc_info.c:get_unwind_n
From: |
Philippe De Muyter |
Subject: |
[Libunwind-devel] typo bug for arm in _UPT_find_proc_info.c:get_unwind_nfo |
Date: |
Thu, 31 Aug 2017 11:22:49 +0200 |
User-agent: |
Mutt/1.5.16 (2007-06-09) |
Hi Dave,
I think I have a spotted a small typo bug. Unfortunately it does not
fix any failure on arm :(
diff --git a/src/ptrace/_UPT_find_proc_info.c b/src/ptrace/_UPT_find_proc_info.c
index b3209f4..aeade56 100644
--- a/src/ptrace/_UPT_find_proc_info.c
+++ b/src/ptrace/_UPT_find_proc_info.c
@@ -47,11 +47,11 @@ get_unwind_info (struct elf_dyn_info *edi, pid_t pid,
unw_addr_space_t as, unw_w
#endif
if ((edi->di_cache.format != -1
&& ip >= edi->di_cache.start_ip && ip < edi->di_cache.end_ip)
#if UNW_TARGET_ARM
- || (edi->di_debug.format != -1
+ || (edi->di_arm.format != -1
&& ip >= edi->di_arm.start_ip && ip < edi->di_arm.end_ip)
#endif
|| (edi->di_debug.format != -1
&& ip >= edi->di_debug.start_ip && ip < edi->di_debug.end_ip))
return 0;
On Fri, Aug 25, 2017 at 07:34:55PM -0700, Dave Watson wrote:
> On 08/25/17 09:54 AM, Philippe De Muyter wrote:
> > Hi Dave,
> >
> > Both patches solve the link error, but the check results are not good :(
> > The first patch gives slightly better results (19 FAIL's instead of 20)
>
> Thanks, will merge the first. Not enough info to fix the tests
> unfortunately. Which compiler are you using? The tests are known to
> be broken on some arches (although 19 is a lot), with the library
> itself working fine.