lightning
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ppc: Fix 'calli' when floating-point arguments are passed


From: Paul Cercueil
Subject: Re: [PATCH] ppc: Fix 'calli' when floating-point arguments are passed
Date: Sat, 03 Sep 2022 16:33:19 +0100

Hi Paulo,
[...]

About the "call" check, I didn't debug it yet, but it may be related to
 calling "near" code as well. I had to use the following temporary
 workaround in my code to avoid crashes:
 https://github.com/pcercuei/lightrec/blob/master/emitter.c#L35-L47

  This is strange. check/*.tst is full of forward and backward jumps.
Not just call.tst has them. But call.tst has a few forward/backward
tests of calls and jumps. Unless the can_sign_extend_jump_p() macro
has some bug in the displacement test, and  was never experienced
in the tests.

What happens is I have a pointer that I keep in the last JIT_V() register, and the jit_jmpi() call uses the same register as a temporary.

Adding a jit_live() right before the jit_jmpi() fixes it, but it makes me wonder why Lightning considered it okay to use this register in the first place.

Cheers,
-Paul





reply via email to

[Prev in Thread] Current Thread [Next in Thread]