|
From: | lilypond |
Subject: | Re: [Lilypond-auto] Issue 2836 in lilypond: LilyPond hangs if NoteHead 'stencil is empty |
Date: | Mon, 22 Oct 2012 10:41:04 +0000 |
Comment #12 on issue 2836 by address@hidden: LilyPond hangs if NoteHead 'stencil is empty
http://code.google.com/p/lilypond/issues/detail?id=2836I don't really like this patch with its mostly unmotivated way of checking for sideeffects of missing stencils (infinite values here, nans there and so on) and slightly correcting for them. If the sideeffects change, the corrections will get bypassed. I think it would be saner to just explicitly check for empty stencil extents in general and directly code behavior intended for that case instead of letting nonsensical values propagate and compensating their effects later on.
Now that is not really relevant to the backporting question except that the sideeffect-based coding approach here might shift the side effects in 2.16 to a place where they are dealt with worse than before.
I don't see any detail in this patch that I consider likely to cause a change to the worse, but as long as it does not fix any problem known to occur also in 2.16, I still see no point in cherry-picking it.
[Prev in Thread] | Current Thread | [Next in Thread] |