Re: [Lilypond-auto] Issue 3723 in lilypond: Patch: Parser: make optional arguments compatible with lookahead

[lilypond]

Updates:
        Status: Fixed
        Labels: -Patch-push Fixed_2_19_0

Comment #7 on issue 3723 by address@hidden: Patch: Parser: make optional  
arguments compatible with lookahead
http://code.google.com/p/lilypond/issues/detail?id=3723

Pushed to staging as a merge commit:
*   commit 0094721cfd7a034bc42f8ee8a30e9fa28f6530d1
|\  Merge: ae72ad8 fbfeabd
| | Author: David Kastrup <address@hidden>
| | Date:   Thu Dec 19 12:21:23 2013 +0100
| |
| |     Merge branch 'issue3723' into staging
| |
| * commit fbfeabd0a1d56114ce5ce6b4a05a82f193deba27
| | Author: David Kastrup <address@hidden>
| | Date:   Fri Dec 13 06:24:17 2013 +0100
| |
| |     Adapt documentation for optional arguments now that lookahead is  
permissible
| |
| * commit ee4b49239c2aeb7ed6b4609391566a276ca0d47c
| | Author: David Kastrup <address@hidden>
| | Date:   Fri Dec 13 06:01:43 2013 +0100
| |
| |     Parser: properly disambiguate pitches from music in function  
arguments
| |
| |     In many instances, function arguments were parsed greedily without
| |     looking at the function argument predicates first.  This did not  
allow
| |     using subsequent function arguments of type pitch and duration since
| |     they were combined into one music expression.
| |
| * commit b676e06cee40ed43c1bd1b998e8959c5924a57e8
| | Author: David Kastrup <address@hidden>
| | Date:   Thu Dec 12 18:57:09 2013 +0100
| |
| |     Parser: remove command_element and command_event synonyms of  
tempo_event
| |
| * commit fbaefa094a049778a2866ba2eefcd842d453c7d4
| | Author: David Kastrup <address@hidden>
| | Date:   Thu Dec 12 17:19:15 2013 +0100
| |
| |     Parser: remove pitch_arg and PITCH_ARG
| |
| * commit ffaadf12aaf98a96d6f6ca1358458dff0405fe14
| | Author: David Kastrup <address@hidden>
| | Date:   Thu Dec 12 16:43:34 2013 +0100
| |
| |     Parser: inline a few "common" expressions occuring only once now
| |
| * commit 07add6e418ce6505300ea092bfcd47d1bc7eaffd
| | Author: David Kastrup <address@hidden>
| | Date:   Wed Dec 11 20:25:29 2013 +0100
| |
| |     Remove all closed music expressions
| |
| * commit 2a984a02e2d85732e92eb1fd95cc0a73fc40c60d
| | Author: David Kastrup <address@hidden>
| | Date:   Wed Oct 30 21:01:39 2013 +0100
| |
| |     Permit event functions to use a non-closed argument list.
| |
| * commit 3360bbddd21fb58f9ad5ca6268f637f6ca15ae4a
| | Author: David Kastrup <address@hidden>
| | Date:   Mon Nov 25 17:29:23 2013 +0100
| |
| |     Add location data to extra_tokens_ stack in lexer.
| |
| * commit afea0e309c9a185b1d061fb397bf318ce8ff2fe9
| | Author: David Kastrup <address@hidden>
| | Date:   Thu Dec 12 15:34:33 2013 +0100
| |
| |     Parser: let MYREPARSE and MYBACKUP back up even in presence of  
lookahead
| |
| |     This implies that the lookahead token must not yet have made an  
impact
| |     on the state stack other than causing the reduction of the current
| |     rule, or switching the lookahead token while Bison is mulling it  
over
| |     will cause trouble.
| |
| |     Since an LALR(1) works on the top of the stack, this can usually be
| |     guaranteed.  The "Too much lookahead" message is not produced.  If
| |     these constructs are misused, the parser should typically complain
| |     about the replacement token being unexpected.
| |
| |     The advantage is the ability to vastly simplify syntax rules that up
| |     to now have to avoid lookahead tokens with a lot of drudgework.
| |
| * commit 5bf2b8b2d50667582a61abea0e6257be0d033131
|/  Author: David Kastrup <address@hidden>
|   Date:   Wed Dec 11 21:35:53 2013 +0100
|
|       Move the extra_token mechanism out of the lexer proper
|
|       Calling lex->pop_extra_token explicitly in the parser's yylex  
function
|       makes things considerably more robust.  It also allows pushing and
|       popping the EOF condition, necessary for backing up right at the end
|       of a file, like with ##{ \relative { c d e f } #} where the music
|       expression is checked against being a pitch, and then is backed up.


--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings