[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #4704 Improve beam count handling with subdivided beams

[Auto mailings of changes to Lily Issues]

Please always include at least the full unabbreviated commit ids, preferably also at least the summary line of the commit message.

If you don't include the full unabbreviated commit id and a particular commit is found to have caused a problem later on, it becomes much harder finding it in the tracker since nobody has an idea just how many digits of an abbreviated commit id to search for.

In general, don't invent your own standards without asking back on the developer list: for many established practices there is an underlying reason and rationale that may not be readily apparent.

Thanks

---

[issues:#4704] Improve beam count handling with subdivided beams

Status: Fixed
Labels: Fixed_2_19_35
Created: Mon Dec 21, 2015 09:44 PM UTC by Urs Liska
Last Updated: Tue Dec 29, 2015 10:58 AM UTC
Owner: Urs Liska

Improve beam count handling with subdivided beams

Subdivision beam count was improved in issue 4355, commit 8fa2d858,
but partially reverted in commit 0382ed88.

• Before 4355 there was always one beam at the subdivision
• After 4355 the beam count reflected the metric value of
  the subdivision's location
• After commit 8fa2d858 the beam count matched baseMoment

The behaviour after 4355 is correct as it gives an immediate
feedback on the metric situation, and is suggested by Gould.
The later revert was to avoid a side-effect, namely the inconsistency
with shortened beams: If the remaining length of the beam is less
than the length of the current metric group the result was
confusing.

This patch reverts the effect of the latest commit, reinstating
the behaviour of issue 4355. However, it improves handling to
remove the unwanted side-effect:
- when the remaining length of the beam is shorter than the
next group (e.g. subdivision at an 1/8 point, but only 3/32
left) the beam count matches the length of the remainder:
1/16 <= remainder < 1/8 => 2 beams
1/32 <= remainder < 1/16 => 3 beams
etc.
- but if only one stem is left after the subdivision this is not
applied. The subdivision has the regular number matching the
metric value, and the trailing single stem has beamlets according
to its actual length

http://codereview.appspot.com/276560043

---

Sent from sourceforge.net because address@hidden is subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------

_______________________________________________
Testlilyissues-auto mailing list
address@hidden
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto