|
From: | Auto mailings of changes to Lily Issues via Testlilyissues-auto |
Subject: | [Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5524 New function css-color (accompanying x11-color) |
Date: | Wed, 05 Jun 2019 19:28:44 -0000 |
Reviewers: ,
Message:
This is a follow-up patch to
https://codereview.appspot.com/570690043/
For some reason it was uploaded as a new patch,
and Issue
https://sourceforge.net/p/testlilyissues/issues/5524/
wasn't updated.
This new patch attempts a cleaner separation of color
definitions between X11 and CSS colors, avoiding
duplication.
As with the original patch, I'll document it when
there's basic agreement.
Description:
New function css-color
X11 and CSS colors are now independently accessible through #(x11-color
<name>)
or #(css-color <name>).
Both color models are now completely case insensitive (as they should
be),
and spaces are simply stripped from the argument. That way all
combinations
of symbols/strings, CamelCased or lowercase etc. are accepted.
If no color is found by the requested name a warning is issued
(unfortunately that can't be an input warning).
Please review this at https://codereview.appspot.com/580780043/
[issues:#5524] New function css-color (accompanying x11-color)
Status: Started
Created: Mon Jun 03, 2019 02:49 PM UTC by Urs Liska
Last Updated: Wed Jun 05, 2019 05:25 PM UTC
Owner: Urs Liska
New function css-color (accompanying x11-color)
I was asked if LilyPond could support choosing colors by their CSS name,
which I found a reasonable wish.
This commit makes make-x11-color-handler generic and specifies
a new function css-color. From this it would be easy to also add further
namespaces and color lists.
CSS colors are case insensitive, so this commit also provides support for
this. Incidentally, a warning is now issued when the requested color is
not defined (instead of silently falling back to black).
http://codereview.appspot.com/570690043
Sent from sourceforge.net because testlilyissues-auto@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/
To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
_______________________________________________ Testlilyissues-auto mailing list address@hidden https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Prev in Thread] | Current Thread | [Next in Thread] |