|
From: | lemzwerg |
Subject: | Re: Issue 5565: simplify python-related makefiles (issue 581080044 by address@hidden) |
Date: | Wed, 02 Oct 2019 21:27:00 -0700 |
LGTM. https://codereview.appspot.com/581080044/diff/578940043/stepmake/stepmake/python-module-rules.make File stepmake/stepmake/python-module-rules.make (right): https://codereview.appspot.com/581080044/diff/578940043/stepmake/stepmake/python-module-rules.make#newcode1 stepmake/stepmake/python-module-rules.make:1: .DELETE_ON_ERROR: Looking into the info file of make it seems that DELETE_ON_ERROR has a global meaning. If this is true I suggest that you put it into the topmost make file. https://codereview.appspot.com/581080044/
[Prev in Thread] | Current Thread | [Next in Thread] |