Re: Fix underline-markup to make multiple calls have nice output (issue 559150043 by address@hidden)

[dak]

On 2019/10/21 15:36:04, thomasmorley651 wrote:

> Then we would have the following properties
> ((thickness 1) (offset 2) (underline-shift 0) (underline-offset 2))

> A user-override for underline-shift would disturb things, though.
Maybe some
> words in the doc-string about it?

Having both offset and underline-offset is confusing.  For spacing
between equal things we usually use distance, not offset (at least there
is basic-distance or was that baseline-skip ?).  So it would be
thickness, offset, underline-shift, underline-distance.  Or
underline-skip ?  Probably the latter because it does not include
padding, thickness, etc.  Or should it?

Life is complicated.

https://codereview.appspot.com/559150043/