[Linphone-users] Re: segfault in ortp-0.10.0

[Simon Morlat]

Thanks a lot for reporting this problem.
I' ve fixed the problem differently in the way that I simply do not send SDES 
packets if session->sd is not defined.

Simon

Le jeudi 15 juin 2006 14:09, Andre Noll a écrit :
> Hi Simon,
>
> I'm getting this with ortp-0.10.0:
>
> Program received signal SIGSEGV, Segmentation fault.
> [Switching to Thread -1214494096 (LWP 23756)]
> 0xb7b2c304 in sdes_chunk_set_ssrc (m=0x0, ssrc=0) at rtcp.c:70
> 70              sc->csrc=htonl(ssrc);
> (gdb) bt
> #0  0xb7b2c304 in sdes_chunk_set_ssrc (m=0x0, ssrc=0) at rtcp.c:70
> #1  0xb7b2ca93 in rtp_session_create_rtcp_sdes_packet (session=0x806bf98)
> at rtcp.c:141 #2  0xb7b2cce9 in rtp_session_rtcp_process_recv
> (session=0x806bf98) at rtcp.c:288 #3  0xb7b27341 in
> rtp_session_recvm_with_ts (session=0x806bf98, user_ts=40144) at
> rtpsession.c:983
> #4  0x0805b091 in ortp_recv_post_select (s=0xbfe08c00, t=0x806bccc) at
> ortp_recv.c:147
>
> The segfault is due to session->sd being NULL. The patch below fixes the
> problem for me.
>
> Have fun
> Andre
>
>
> --- src/rtcp.c~       2006-06-15 14:00:31.000000000 +0200
> +++ src/rtcp.c        2006-06-15 14:01:10.000000000 +0200
> @@ -321,6 +321,8 @@ void rtp_session_rtcp_process_send(RtpSe
>  void rtp_session_rtcp_process_recv(RtpSession *session){
>       RtpStream *st=&session->rtp;
>       mblk_t *m;
> +     if (!session->sd)
> +             return;
>       if (st->rcv_last_app_ts - st->last_rtcp_report_snt_r >
> st->rtcp_report_snt_interval
>
>               || st->snd_last_ts - st->last_rtcp_report_snt_s >
>               || st->rtcp_report_snt_interval){
>
>               st->last_rtcp_report_snt_r=st->rcv_last_app_ts;