Re: [Linphone-users] FIX: linphonec failed to register

[Gautier Pelloux-Prayer]

Hi,

Thanks for reporting, indeed there was a regression in register command. It 
should be fixed in 83f6597.

Cheers,

Gautier Pelloux-Prayer
Software Engineer @ Belledonne Communications

> On 07 May 2015, at 09:33, Pavel Nakonechny <address@hidden> wrote:
> 
> Hi all!
> 
> There is a bug in linphonec code that was introduced in commit
> 0177c5f876e8b0d15a33a1c77bf704aede036ad3. When you are trying to
> register via command "register", the process will fail and ask for
> password again, even if you supplied a password earlier.
> 
> Command example:
> 
> "register sip:address@hidden sip:192.168.1.1;transport=udp 111"
> 
> current answer: "Registration on <sip:192.168.1.1;transport=udp>
> failed: Unauthorized
> linphonec>
> Password for 600 on 192.168.1.1:"
> 
> proper answer: "Registration on <sip:192.168.1.1;transport=udp> successful."
> 
> Patch to fix it:
> ++++
> From 6bee797bb8d0609a3a5cd84fe00d737201791f67 Mon Sep 17 00:00:00 2001
> From: Pavel Nakonechny <address@hidden>
> Date: Thu, 7 May 2015 10:28:54 +0300
> Subject: [PATCH] linphonec: fix registration with password supplied
> 
> In commit 0177c5f876e8b0d15a33a1c77bf704aede036ad3 a bug was introduced,
> that leads to failure in the process of authorization with password
> supplied on command line, i.e.:
> 
> register sip:address@hidden sip:192.168.1.1;transport=udp 111
> 
> This commit fixes that by changing arguments, that going to
> linphone_auth_info_new() function.
> ---
> console/commands.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/console/commands.c b/console/commands.c
> index cd968f5..09aa9ed 100644
> --- a/console/commands.c
> +++ b/console/commands.c
> @@ -1943,7 +1943,7 @@ static int lpc_cmd_register(LinphoneCore *lc, char 
> *args){
>                LinphoneAddress *from;
>                LinphoneAuthInfo *info;
>                if ((from=linphone_address_new(identity))!=NULL){
> -
> info=linphone_auth_info_new(NULL,NULL,passwd,NULL,NULL,linphone_address_get_username(from));
> +
> info=linphone_auth_info_new(linphone_address_get_username(from), NULL,
> passwd, NULL, NULL, linphone_address_get_domain(from));
>                        linphone_core_add_auth_info(lc,info);
>                        linphone_address_destroy(from);
>                        linphone_auth_info_destroy(info);
> --
> 2.1.4
> ++++
> 
> PS: probably, there are more such errors throughout source tree.
> 
> 
> --
> WBR, Pavel
> 
> _______________________________________________
> Linphone-users mailing list
> address@hidden
> https://lists.nongnu.org/mailman/listinfo/linphone-users