Re: [Linphone-users] using __linux__ instead of __linux

[Peio Rigaux]

Hello.

Gitlab accounts creation is locked because we chose to focus on the management of our customers there, and because we also need to limit the number of accounts in case we would need paid support from them.

But you can do pull requests on our Github mirrors. I had very little time to check them in the past months but I give a look every once in a while.

I just verified on the latest version of Liblinphone (master), and your suggestion seems to have been integrated.

Some "__linux" occurrences are still present in openldap submodule, but you can just disable LDAP at the build time if you don't need it.

Thanks for your report.

Regards,

Peio Rigaux
Junior DevOps Engineer
Belledonne Communications, the company behind Linphone
Linphone.org

Le 01/07/2021 à 01:15, Daniel Pocock a écrit :

> I found __linux in Linphone.  It is not completely portable on all
> architectures, here is a similar bug in libusb:
>
> https://github.com/libusb/libusb/pull/315
>
>
>
> I had to patch it here to make it compile, I can't submit the patch
> because it looks like Gitlab doesn't allow developers to create new
> accounts.  If somebody can help me with a Gitlab account I'll be happy
> to submit the merge request for this.
>
> https://gitlab.linphone.org/BC/public/liblinphone
>
>
> It is necessary to replace __linux with __linux__ in each of these files:
>
>
> $ find . -type f -name '*.c*' -exec grep -H __linux {} \;
>
> ./coreapi/linphonecore.c:#ifdef __linux
>
> ./src/core/paths/paths.cpp:#elif defined(__linux)
>
> ./tester/liblinphone_tester.c:#ifdef __linux
>
> ./tester/message_tester.c:#if defined(__linux__) && !defined(__ANDROID__)
>
> ./tester/register_tester.c:#ifdef __linux
>
> ./tester/setup_tester.c:#elif defined(__linux) || (defined(__APPLE__) &&
> !TARGET_OS_IPHONE) || defined(_WIN32)
>
> ./obj-powerpc64le-linux-gnu/CMakeFiles/3.16.3/CompilerIdC/CMakeCCompilerId.c:#if
> defined(__linux) || defined(__linux__) || defined(linux)
>
> ./obj-powerpc64le-linux-gnu/CMakeFiles/3.16.3/CompilerIdCXX/CMakeCXXCompilerId.cpp:#if
> defined(__linux) || defined(__linux__) || defined(linux)
>
> _______________________________________________
> Linphone-users mailing list
> Linphone-users@nongnu.org
> https://lists.nongnu.org/mailman/listinfo/linphone-users
>

OpenPGP_0x99D28356FED78143.asc
Description: OpenPGP public key

OpenPGP_signature
Description: OpenPGP digital signature