[liquidwar-user] LANG environment variable

[David Turner]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all,

I had a bit of trouble getting v5.5.1 to run on my system; turns out it 
segfaults if the LANG environment variable is not set because it tries to run 
strncmp on a null pointer. Patch attached, session log below.

(I am not on this list so please CC me in if you want to reply)

Cheers,
Dave


$ unset LANG
$ ./liquidwar
Starting Allegro (http://www.talula.demon.co.uk/allegro)

Allegro ID : Allegro 4.0.1, Unix

Loading config options from "/home/dct25/.liquidwarrc" - success!
Installing timer (driver="Unix pthreads timers") - success!
Installing keyboard (driver="X-Windows keyboard") - success!
Installing mouse (driver="X-Windows mouse") - success!
Installing sound (digi="No sound", midi="No sound") - success!
Installing joystick (driver="No joystick") - success!
Setting up network - success!
Allocating 16384 kb - success!

Loading data from "/home/dct25/share/games/liquidwar/liquidwar.dat" - success!
Loading fonts - success!
Loading maps - success!
Loading background bitmap - success!
Loading sound fx - success!
Loading textures - success!
Loading water sounds - success!
Loading midi music - success!

Loading custom textures from "/home/dct25/share/games/liquidwar/texture" ++++ 
- - success!
Loading custom maps from "/home/dct25/share/games/liquidwar/map" +++ - 
success! Loading custom musics from "/home/dct25/share/games/liquidwar/music" 
+ - success!

Changing video mode to 640x480, fullscreen (driver="X11 window") - success!
Shutting down Allegro due to signal #11
Segmentation fault (core dumped)
$ gdb liquidwar core.11372
GNU gdb 5.0
Copyright 2000 Free Software Foundation, Inc.
GDB is free software, covered by the GNU General Public License, and you are
welcome to change it and/or distribute copies of it under certain conditions.
Type "show copying" to see the conditions.
There is absolutely no warranty for GDB.  Type "show warranty" for details.
This GDB was configured as "i686-pc-linux-gnu"...
Core was generated by `./liquidwar'.
Program terminated with signal 11, Segmentation fault.
Reading symbols from /usr/lib/liballeg.so.4.0...done.
Loaded symbols for /usr/lib/liballeg.so.4.0
Reading symbols from /lib/libc.so.6...done.
Loaded symbols for /lib/libc.so.6
Reading symbols from /lib/libm.so.6...done.
Loaded symbols for /lib/libm.so.6
Reading symbols from /lib/libpthread.so.0...done.
rw_common (): write: Success.

warning: unable to set global thread event mask
[New Thread 1024 (LWP 11372)]
rw_common (): write: Success.

warning: stop_or_attach_thread: generic error
[New Thread 2049 (LWP 11373)]
Error while reading shared library symbols:
attach_thread: No such process.
Reading symbols from /usr/X11R6/lib/libXext.so.6...done.
Loaded symbols for /usr/X11R6/lib/libXext.so.6
Reading symbols from /usr/X11R6/lib/libX11.so.6...done.
Loaded symbols for /usr/X11R6/lib/libX11.so.6
Reading symbols from /lib/libdl.so.2...done.
Loaded symbols for /lib/libdl.so.2
Reading symbols from /lib/ld-linux.so.2...done.
Loaded symbols for /lib/ld-linux.so.2
Reading symbols from /lib/libnss_files.so.2...done.
Loaded symbols for /lib/libnss_files.so.2
#0  strncmp (s1=0x807faf6 "R", s2=0x0, n=2) at ../sysdeps/generic/strncmp.c:65
65      ../sysdeps/generic/strncmp.c: No such file or directory.
(gdb) bt
#0  strncmp (s1=0x807faf6 "R", s2=0x0, n=2) at ../sysdeps/generic/strncmp.c:65
#1  0x805eaf6 in lw_lang_auto () at eval.c:88
#2  0x805eb34 in lw_lang_string () at eval.c:88
#3  0x8058466 in quick_buttons () at eval.c:88
#4  0x8061add in main_menu () at eval.c:88
#5  0x8060dc5 in _mangled_main () at eval.c:88
#6  0x400a6e3b in main () at eval.c:88
(gdb) q
$ export LANG=
$ ./liquidwar
Starting Allegro (http://www.talula.demon.co.uk/allegro)

Allegro ID : Allegro 4.0.1, Unix

Loading config options from "/home/dct25/.liquidwarrc" - success!
Installing timer (driver="Unix pthreads timers") - success!
Installing keyboard (driver="X-Windows keyboard") - success!
Installing mouse (driver="X-Windows mouse") - success!
Installing sound (digi="No sound", midi="No sound") - success!
Installing joystick (driver="No joystick") - success!
Setting up network - success!
Allocating 16384 kb - success!

Loading data from "/home/dct25/share/games/liquidwar/liquidwar.dat" - success!
Loading fonts - success!
Loading maps - success!
Loading background bitmap - success!
Loading sound fx - success!
Loading textures - success!
Loading water sounds - success!
Loading midi music - success!

Loading custom textures from "/home/dct25/share/games/liquidwar/texture" ++++ 
- - success!
Loading custom maps from "/home/dct25/share/games/liquidwar/map" +++ - 
success! Loading custom musics from "/home/dct25/share/games/liquidwar/music" 
+ - success!

Changing video mode to 640x480, fullscreen (driver="X11 window") - success!

Leaving Allegro (http://www.talula.demon.co.uk/allegro)

Liquid War by U-Foot
 
v5.5.1 compiled on Jun 20 2002 at 13:34:26
Copyright (C) 1998-2002 Christian Mauduit
 
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
 
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.
 
You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 
Liquid War homepage : http://www.ufoot.org/liquidwar
Contact author      : address@hidden
 
Thanks for playing Liquid War, I hope you enjoyed it!
$

- -- 
Dave Turner
address@hidden
-----BEGIN PGP SIGNATURE-----

iEYEARECAAYFAj0R1DgACgkQyPTaXWib+Hb3XwCfcl08Oyf3avuGJrwSZge5lV5n
2a4An01VrwKZ1gpK7SkbTSuUQtbC99FB
=lR3h
-----END PGP SIGNATURE-----

liquidwar-5.5.1-LANG-bug.patch
Description: Text Data