[lmi-commits] [lmi] master 6fa76ee 1/3: Strictly forbid inforce illustrations in month of issue

[Greg Chicares]

branch: master
commit 6fa76eebaff747badc70f5eba450f3d609282941
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Strictly forbid inforce illustrations in month of issue
    
    Formerly, this was forbidden only for input files from external sources.
    The (flawed) reasoning was that entering an infelicitous set of dates
    made it impossible to edit the file and correct the error. However, only
    Input::set_inforce_durations_from_dates() prevents such manual recovery;
    the code changed in this commit never did.
---
 ledger_invariant.cpp | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/ledger_invariant.cpp b/ledger_invariant.cpp
index c3dcb2c..a6bf514 100644
--- a/ledger_invariant.cpp
+++ b/ledger_invariant.cpp
@@ -909,21 +909,12 @@ void LedgerInvariant::Init(BasicValues const* b)
         )[0];
 
     IsInforce = b->yare_input_.EffectiveDate != b->yare_input_.InforceAsOfDate;
+
     // This test is probably redundant because it is already performed
     // in class Input. But it's difficult to prove that it is actually
     // redundant and will always remain so, while repeating it here
     // costs little and gives a stronger guarantee that illustrations
     // that would violate this rule cannot be produced.
-// Fails:
-//   File | New | Illustration
-//   subtract one day from "Effective date"
-//   OK
-//   Illustration | Edit cell... [fails irrecoverably]
-// Therefore, these diagnostics are temporarily suppressed for input
-// files created by lmi--but not for extracts from vendor systems,
-// whose dates should not be altered by lmi users.
-if(1 != b->yare_input_.InforceDataSource)
-  {
     if(IsInforce && (0 == b->yare_input_.InforceYear && 0 == 
b->yare_input_.InforceMonth))
         {
         alarum()
@@ -931,7 +922,6 @@ if(1 != b->yare_input_.InforceDataSource)
             << LMI_FLUSH
             ;
         }
-  }
 
     SupplementalReport         = b->yare_input_.CreateSupplementalReport;
     SupplementalReportColumn00 = 
mc_str(b->yare_input_.SupplementalReportColumn00);