[lmi-commits] [lmi] master eebb410: Change the line that provokes gcc-8.x '-Wuseless-cast' diagnostics

[Greg Chicares]

branch: master
commit eebb4109948cf3ed7c509ec4583d578a13db2099
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Change the line that provokes gcc-8.x '-Wuseless-cast' diagnostics
    
    Ostensibly because of this updated boost patch, the same diagnostic need
    no longer be suppressed for one list of boost sources in the makefile,
    even for gcc-7.x .
    
    To verify that all vestiges of recent temporary workarounds have been
    removed, run this command:
      git diff f4c47d6e THIS-SHA1 workhorse.make
    substituting this commit's SHA1 where indicated.
    
    To apply the patch and rebuild, use the applicable commands given in
    'install_mingw.make', viz.:
    
      make $coefficiency --output-sync=recurse -f install_miscellanea.make \
       clobber
    
      make $coefficiency --output-sync=recurse -f install_miscellanea.make
    
    then rebuild lmi as usual.
---
 boost_1_33_1.patch | 38 +++++++++++++++++++++++++-------------
 workhorse.make     | 14 --------------
 2 files changed, 25 insertions(+), 27 deletions(-)

diff --git a/boost_1_33_1.patch b/boost_1_33_1.patch
index 0611017..02ae517 100644
--- a/boost_1_33_1.patch
+++ b/boost_1_33_1.patch
@@ -1,6 +1,6 @@
 diff --recursive '--unified=3' original/boost_1_33_1/boost/mpl/apply.hpp 
modified/boost_1_33_1/boost/mpl/apply.hpp
 --- original/boost_1_33_1/boost/mpl/apply.hpp  2004-09-02 15:40:41.000000000 
+0000
-+++ modified/boost_1_33_1/boost/mpl/apply.hpp  2015-12-18 04:02:14.640625000 
+0000
++++ modified/boost_1_33_1/boost/mpl/apply.hpp  2019-03-20 23:47:48.629517270 
+0000
 @@ -135,7 +135,10 @@
  
  ///// iteration, depth == 1
@@ -21,7 +21,7 @@ diff --recursive '--unified=3' 
original/boost_1_33_1/boost/mpl/apply.hpp modifie
  #endif // BOOST_PP_IS_ITERATING
 diff --recursive '--unified=3' original/boost_1_33_1/boost/mpl/apply_wrap.hpp 
modified/boost_1_33_1/boost/mpl/apply_wrap.hpp
 --- original/boost_1_33_1/boost/mpl/apply_wrap.hpp     2004-09-03 
15:56:55.000000000 +0000
-+++ modified/boost_1_33_1/boost/mpl/apply_wrap.hpp     2015-12-18 
04:02:14.640625000 +0000
++++ modified/boost_1_33_1/boost/mpl/apply_wrap.hpp     2019-03-20 
23:47:48.629517270 +0000
 @@ -78,7 +78,10 @@
  
  ///// iteration, depth == 1
@@ -42,7 +42,7 @@ diff --recursive '--unified=3' 
original/boost_1_33_1/boost/mpl/apply_wrap.hpp mo
  #endif // BOOST_PP_IS_ITERATING
 diff --recursive '--unified=3' 
original/boost_1_33_1/boost/mpl/aux_/advance_backward.hpp 
modified/boost_1_33_1/boost/mpl/aux_/advance_backward.hpp
 --- original/boost_1_33_1/boost/mpl/aux_/advance_backward.hpp  2004-09-02 
15:40:43.000000000 +0000
-+++ modified/boost_1_33_1/boost/mpl/aux_/advance_backward.hpp  2015-12-18 
04:02:14.593750000 +0000
++++ modified/boost_1_33_1/boost/mpl/aux_/advance_backward.hpp  2019-03-20 
23:47:48.629517270 +0000
 @@ -79,7 +79,10 @@
  
  ///// iteration, depth == 1
@@ -63,7 +63,7 @@ diff --recursive '--unified=3' 
original/boost_1_33_1/boost/mpl/aux_/advance_back
  #endif // BOOST_PP_IS_ITERATING
 diff --recursive '--unified=3' 
original/boost_1_33_1/boost/mpl/aux_/advance_forward.hpp 
modified/boost_1_33_1/boost/mpl/aux_/advance_forward.hpp
 --- original/boost_1_33_1/boost/mpl/aux_/advance_forward.hpp   2004-09-02 
15:40:43.000000000 +0000
-+++ modified/boost_1_33_1/boost/mpl/aux_/advance_forward.hpp   2015-12-18 
04:02:14.609375000 +0000
++++ modified/boost_1_33_1/boost/mpl/aux_/advance_forward.hpp   2019-03-20 
23:47:48.629517270 +0000
 @@ -79,7 +79,10 @@
  
  ///// iteration, depth == 1
@@ -84,7 +84,7 @@ diff --recursive '--unified=3' 
original/boost_1_33_1/boost/mpl/aux_/advance_forw
  #endif // BOOST_PP_IS_ITERATING
 diff --recursive '--unified=3' 
original/boost_1_33_1/boost/mpl/aux_/full_lambda.hpp 
modified/boost_1_33_1/boost/mpl/aux_/full_lambda.hpp
 --- original/boost_1_33_1/boost/mpl/aux_/full_lambda.hpp       2004-09-04 
01:10:19.000000000 +0000
-+++ modified/boost_1_33_1/boost/mpl/aux_/full_lambda.hpp       2015-12-18 
04:02:14.593750000 +0000
++++ modified/boost_1_33_1/boost/mpl/aux_/full_lambda.hpp       2019-03-20 
23:47:48.629517270 +0000
 @@ -227,7 +227,10 @@
  
  ///// iteration, depth == 1
@@ -105,7 +105,7 @@ diff --recursive '--unified=3' 
original/boost_1_33_1/boost/mpl/aux_/full_lambda.
  #endif // BOOST_PP_IS_ITERATING
 diff --recursive '--unified=3' 
original/boost_1_33_1/boost/mpl/aux_/numeric_op.hpp 
modified/boost_1_33_1/boost/mpl/aux_/numeric_op.hpp
 --- original/boost_1_33_1/boost/mpl/aux_/numeric_op.hpp        2004-12-20 
19:17:06.000000000 +0000
-+++ modified/boost_1_33_1/boost/mpl/aux_/numeric_op.hpp        2015-12-18 
04:02:14.578125000 +0000
++++ modified/boost_1_33_1/boost/mpl/aux_/numeric_op.hpp        2019-03-20 
23:47:48.629517270 +0000
 @@ -287,7 +287,10 @@
  
  ///// iteration, depth == 1
@@ -124,9 +124,21 @@ diff --recursive '--unified=3' 
original/boost_1_33_1/boost/mpl/aux_/numeric_op.h
  
 +#endif // BOOST_PP_ITERATION_DEPTH()
  #endif // BOOST_PP_IS_ITERATING
+diff --recursive '--unified=3' 
original/boost_1_33_1/boost/mpl/aux_/static_cast.hpp 
modified/boost_1_33_1/boost/mpl/aux_/static_cast.hpp
+--- original/boost_1_33_1/boost/mpl/aux_/static_cast.hpp       2004-09-02 
15:40:44.000000000 +0000
++++ modified/boost_1_33_1/boost/mpl/aux_/static_cast.hpp       2019-03-20 
23:51:15.951618377 +0000
+@@ -21,7 +21,7 @@
+  || BOOST_WORKAROUND(__MWERKS__, <= 0x3001)
+ #   define BOOST_MPL_AUX_STATIC_CAST(T, expr) (T)(expr)
+ #else
+-#   define BOOST_MPL_AUX_STATIC_CAST(T, expr) static_cast<T>(expr)
++#   define BOOST_MPL_AUX_STATIC_CAST(T, expr) (T)(expr)
+ #endif
+ 
+ #endif // BOOST_MPL_AUX_STATIC_CAST_HPP_INCLUDED
 diff --recursive '--unified=3' original/boost_1_33_1/boost/mpl/bind.hpp 
modified/boost_1_33_1/boost/mpl/bind.hpp
 --- original/boost_1_33_1/boost/mpl/bind.hpp   2004-10-26 14:51:04.000000000 
+0000
-+++ modified/boost_1_33_1/boost/mpl/bind.hpp   2015-12-18 04:02:14.625000000 
+0000
++++ modified/boost_1_33_1/boost/mpl/bind.hpp   2019-03-20 23:47:48.629517270 
+0000
 @@ -361,7 +361,10 @@
  
  ///// iteration, depth == 1
@@ -147,7 +159,7 @@ diff --recursive '--unified=3' 
original/boost_1_33_1/boost/mpl/bind.hpp modified
  #endif // BOOST_PP_IS_ITERATING
 diff --recursive '--unified=3' original/boost_1_33_1/boost/mpl/unpack_args.hpp 
modified/boost_1_33_1/boost/mpl/unpack_args.hpp
 --- original/boost_1_33_1/boost/mpl/unpack_args.hpp    2004-09-02 
15:40:42.000000000 +0000
-+++ modified/boost_1_33_1/boost/mpl/unpack_args.hpp    2015-12-18 
04:02:14.625000000 +0000
++++ modified/boost_1_33_1/boost/mpl/unpack_args.hpp    2019-03-20 
23:47:48.629517270 +0000
 @@ -111,7 +111,10 @@
  
  ///// iteration, depth == 1
@@ -168,7 +180,7 @@ diff --recursive '--unified=3' 
original/boost_1_33_1/boost/mpl/unpack_args.hpp m
  #endif // BOOST_PP_IS_ITERATING
 diff --recursive '--unified=3' 
original/boost_1_33_1/boost/numeric/ublas/detail/vector_assign.hpp 
modified/boost_1_33_1/boost/numeric/ublas/detail/vector_assign.hpp
 --- original/boost_1_33_1/boost/numeric/ublas/detail/vector_assign.hpp 
2005-07-01 20:09:01.000000000 +0000
-+++ modified/boost_1_33_1/boost/numeric/ublas/detail/vector_assign.hpp 
2015-12-18 04:34:52.000000000 +0000
++++ modified/boost_1_33_1/boost/numeric/ublas/detail/vector_assign.hpp 
2019-03-20 23:47:48.629517270 +0000
 @@ -139,7 +139,10 @@
      void vector_assign_scalar (V &v, const T &t, dense_proxy_tag) {
  #ifdef BOOST_UBLAS_USE_INDEXING
@@ -211,7 +223,7 @@ diff --recursive '--unified=3' 
original/boost_1_33_1/boost/numeric/ublas/detail/
      // Packed (proxy) case
 diff --recursive '--unified=3' 
original/boost_1_33_1/boost/numeric/ublas/vector_expression.hpp 
modified/boost_1_33_1/boost/numeric/ublas/vector_expression.hpp
 --- original/boost_1_33_1/boost/numeric/ublas/vector_expression.hpp    
2005-07-13 05:57:36.000000000 +0000
-+++ modified/boost_1_33_1/boost/numeric/ublas/vector_expression.hpp    
2015-12-18 04:33:06.000000000 +0000
++++ modified/boost_1_33_1/boost/numeric/ublas/vector_expression.hpp    
2019-03-20 23:47:48.629517270 +0000
 @@ -1388,7 +1388,10 @@
          value_type evaluate (dense_random_access_iterator_tag) const {
  #ifdef BOOST_UBLAS_USE_INDEXING
@@ -254,7 +266,7 @@ diff --recursive '--unified=3' 
original/boost_1_33_1/boost/numeric/ublas/vector_
  
 diff --recursive '--unified=3' original/boost_1_33_1/libs/regex/src/cregex.cpp 
modified/boost_1_33_1/libs/regex/src/cregex.cpp
 --- original/boost_1_33_1/libs/regex/src/cregex.cpp    2005-03-30 
11:38:32.000000000 +0000
-+++ modified/boost_1_33_1/libs/regex/src/cregex.cpp    2015-12-18 
05:12:08.031250000 +0000
++++ modified/boost_1_33_1/libs/regex/src/cregex.cpp    2019-03-20 
23:47:48.633517467 +0000
 @@ -362,7 +362,7 @@
  #if BOOST_WORKAROUND(BOOST_MSVC, >= 1400)
           (::sprintf_s)(buf, sizeof(buf), "%s%s%s", dstart.path(), 
directory_iterator::separator(), ptr);
@@ -266,7 +278,7 @@ diff --recursive '--unified=3' 
original/boost_1_33_1/libs/regex/src/cregex.cpp m
           ++dstart;
 diff --recursive '--unified=3' 
original/boost_1_33_1/libs/regex/src/fileiter.cpp 
modified/boost_1_33_1/libs/regex/src/fileiter.cpp
 --- original/boost_1_33_1/libs/regex/src/fileiter.cpp  2005-03-30 
11:38:32.000000000 +0000
-+++ modified/boost_1_33_1/libs/regex/src/fileiter.cpp  2015-12-18 
05:12:08.046875000 +0000
++++ modified/boost_1_33_1/libs/regex/src/fileiter.cpp  2019-03-20 
23:47:48.633517467 +0000
 @@ -30,7 +30,6 @@
  #include <cstdio>
  #if defined(BOOST_NO_STDC_NAMESPACE)
@@ -289,7 +301,7 @@ diff --recursive '--unified=3' 
original/boost_1_33_1/libs/regex/src/fileiter.cpp
     {
 diff --recursive '--unified=3' 
original/boost_1_33_1/libs/regex/src/posix_api.cpp 
modified/boost_1_33_1/libs/regex/src/posix_api.cpp
 --- original/boost_1_33_1/libs/regex/src/posix_api.cpp 2005-03-30 
11:38:32.000000000 +0000
-+++ modified/boost_1_33_1/libs/regex/src/posix_api.cpp 2015-12-18 
05:12:08.046875000 +0000
++++ modified/boost_1_33_1/libs/regex/src/posix_api.cpp 2019-03-20 
23:47:48.633517467 +0000
 @@ -24,7 +24,6 @@
  
  #if defined(BOOST_NO_STDC_NAMESPACE)
diff --git a/workhorse.make b/workhorse.make
index aac4984..895e5f4 100644
--- a/workhorse.make
+++ b/workhorse.make
@@ -505,19 +505,6 @@ gcc_cxx_warnings := \
   -Wreorder \
   -Wstrict-null-sentinel \
   -Wsynth \
-
-# Overriding C++-only warnings by adding '-Wno-' variants such as
-#   -Wno-useless-cast
-# to $(gcc_version_specific_warnings), which is incorporated into
-# both $(CFLAGS) and $(CXXFLAGS), elicits error messages such as
-#   command line option '-Wno-noexcept' is valid for C++/ObjC++ but not for C
-# with gcc-8.x, although it worked fine with earlier versions.
-# Although $(gcc_version_specific_warnings) could be split by
-# language, it is objectionable to complicate this makefile merely
-# in order to work around a gcc regression--so, instead, these two
-# options are temporarily removed from the list above.
-
-temporarily_suppressed_for_gcc_8_x := \
   -Wuseless-cast \
 
 # Consider these later.
@@ -577,7 +564,6 @@ operations_posix_windows.o: gcc_common_extra_warnings += 
-Wno-unused-parameter
 $(boost_filesystem_objects): gcc_common_extra_warnings += \
   -Wno-deprecated-declarations \
   -Wno-unused-macros \
-  -Wno-useless-cast \
 
 $(boost_regex_objects): gcc_common_extra_warnings += \
   -Wno-conversion \