[lmi-commits] [lmi] master 784d552 4/7: Explain why '-Wsign-promo' is not enabled

[Greg Chicares]

branch: master
commit 784d55240c7b55b066ddf018a57775b92eb876d3
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Explain why '-Wsign-promo' is not enabled
---
 workhorse.make | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/workhorse.make b/workhorse.make
index 40cd075..382d8fd 100644
--- a/workhorse.make
+++ b/workhorse.make
@@ -462,11 +462,13 @@ gcc_common_warnings := \
   -Wwrite-strings \
   -Wno-parentheses \
 
-# Consider these later. Exceptions:
+# Warnings that are not generally useful.
 #
 # -Wdate-time: only for "bit-wise-identical reproducible compilations"
 # -Wunsafe-loop-optimizations: incompatible with ranged for-loops
 
+# Consider these later:
+
 postponed_gcc_common_warnings := \
   -Wmissing-declarations \
   -Wnull-dereference \
@@ -507,19 +509,21 @@ gcc_cxx_warnings := \
   -Wsynth \
   -Wuseless-cast \
 
-# Consider these later. Exceptions:
+# Warnings that are not generally useful.
 #
+# -Wsign-promo: too many false positives--see:
+#   https://lists.nongnu.org/archive/html/lmi/2019-03/msg00016.html
 # -Wsuggest-final-methods, and
 # -Wsuggest-final-types: use these only occasionally, like -Weffc++;
 #   work with '-Wsuggest-final-types' first, because making a class
 #   final may resolve '-Wsuggest-final-methods' suggestions for its
-#   members; but expect many false positives.
+#   members; but expect many false positives
+# -Wfloat-equal: too many warnings on correct code, e.g.,
+#   exact comparison to zero
 
-postponed_gcc_cxx_warnings := \
-  -Wsign-promo \
+# Consider these later:
 
-# Too many warnings on correct code, e.g. exact comparison to zero:
-#  -Wfloat-equal \
+postponed_gcc_cxx_warnings := \
 
 gcc_common_extra_warnings := \
   -Wcast-qual \