[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] odd/multiarch 98e00a5 05/10: Explain why one variabl
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] odd/multiarch 98e00a5 05/10: Explain why one variable is unset while another is exported |
Date: |
Wed, 15 May 2019 17:59:55 -0400 (EDT) |
branch: odd/multiarch
commit 98e00a50202ccf6e1e052b2564d091ebffc4c8c2
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>
Explain why one variable is unset while another is exported
---
set_arch.sh | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/set_arch.sh b/set_arch.sh
index 95d4c18..ac25d7d 100755
--- a/set_arch.sh
+++ b/set_arch.sh
@@ -107,7 +107,13 @@ local winebindir="$prefix"/third_party/bin
minimal_path=${MINIMAL_PATH:-"/usr/bin:/bin:/usr/sbin:/sbin"}
export PATH="$localbindir":"$locallibdir":"$minimal_path"
+# It is appropriate to unset $WINEPATH because no lmi script ever uses
+# it directly--it's implicitly used, only by 'wine'. OTOH, $PERFORM is
+# used directly, so it's always exported, even if empty--though that's
+# probably just a matter of taste.
+
unset -v WINEPATH
+export PERFORM
# Are double quotes inside double quotes inside $() dubious? I.e.,
# " $( "is this string quoted?" ) "
@@ -131,9 +137,7 @@ case "$lmi_build_type" in
export WINEPATH="$w0;$w1;$w2"
export PERFORM="wine"
;;
- (*)
- export PERFORM
- ;;
+ (*) ;;
esac
}
- [lmi-commits] [lmi] odd/multiarch updated (992aef4 -> da7b85f), Greg Chicares, 2019/05/15
- [lmi-commits] [lmi] odd/multiarch a0da26f 09/10: Avert shellcheck SC2140 warning, Greg Chicares, 2019/05/15
- [lmi-commits] [lmi] odd/multiarch da7b85f 10/10: Rename set_arch.sh -> set_toolchain.sh, Greg Chicares, 2019/05/15
- [lmi-commits] [lmi] odd/multiarch 4608d81 03/10: Remove obsolete commentary, Greg Chicares, 2019/05/15
- [lmi-commits] [lmi] odd/multiarch 068f52e 06/10: Improve documentation, Greg Chicares, 2019/05/15
- [lmi-commits] [lmi] odd/multiarch 48c0186 08/10: Rephrase for clarity, Greg Chicares, 2019/05/15
- [lmi-commits] [lmi] odd/multiarch fd0b947 07/10: Improve diagnostics, Greg Chicares, 2019/05/15
- [lmi-commits] [lmi] odd/multiarch e95d62e 02/10: Improve documentation, Greg Chicares, 2019/05/15
- [lmi-commits] [lmi] odd/multiarch 98e00a5 05/10: Explain why one variable is unset while another is exported,
Greg Chicares <=
- [lmi-commits] [lmi] odd/multiarch cfc2bad 01/10: Prefer xz to bzip2, Greg Chicares, 2019/05/15
- [lmi-commits] [lmi] odd/multiarch adf0725 04/10: Validate $LMI_COMPILER as well as $LMI_TRIPLET, Greg Chicares, 2019/05/15