[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] master a729e1a 4/7: Regularize argument order
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] master a729e1a 4/7: Regularize argument order |
Date: |
Thu, 13 Jun 2019 20:39:01 -0400 (EDT) |
branch: master
commit a729e1a50f792c5ae7595287ec2640b942ff24b1
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>
Regularize argument order
Rewrote arguments of operator!=() and std::swap in the same order.
Neither order is better in either case. Different orders would seem to
suggest otherwise.
Incidentally, there didn't seem to be any need for a blank line between
the only two lines in a brace-enclosed block.
---
mvc_controller.cpp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mvc_controller.cpp b/mvc_controller.cpp
index 830b528..03497cb 100644
--- a/mvc_controller.cpp
+++ b/mvc_controller.cpp
@@ -347,10 +347,9 @@ void MvcController::ConditionallyEnableItems
wxWindowUpdateLocker u(&control);
- if(items != cached_items)
+ if(cached_items != items)
{
std::swap(cached_items, items);
-
itembox->Set(cached_items);
}
- [lmi-commits] [lmi] master updated (e861045 -> 5fce601), Greg Chicares, 2019/06/13
- [lmi-commits] [lmi] master 5fce601 7/7: Correct a typo, Greg Chicares, 2019/06/13
- [lmi-commits] [lmi] master 92bc792 6/7: Add a 'MinPremType' database entity, Greg Chicares, 2019/06/13
- [lmi-commits] [lmi] master f59aa3a 5/7: Add some useful commands, Greg Chicares, 2019/06/13
- [lmi-commits] [lmi] master a729e1a 4/7: Regularize argument order,
Greg Chicares <=
- [lmi-commits] [lmi] master 7bc7a7b 3/7: Include standard header for std::swap(), Greg Chicares, 2019/06/13
- [lmi-commits] [lmi] master 362d02d 1/7: Cache items of wxItemContainer in MvcController, Greg Chicares, 2019/06/13
- [lmi-commits] [lmi] master 9ec7d83 2/7: Update item selection of wxItemContainer only when necessary, Greg Chicares, 2019/06/13