[lmi-commits] [lmi] master b5530c3 1/2: Remove 'PolicyLegalName' from spreadsheet output

[Greg Chicares]

branch: master
commit b5530c30d6ab68afff2cfd7e9f8b506844dcbb33
Author: Gregory W. Chicares <address@hidden>
Commit: Gregory W. Chicares <address@hidden>

    Remove 'PolicyLegalName' from spreadsheet output
    
    'PolicyLegalName', a policy's formal caption, exists only for compliance
    purposes. It's unnecessary for spreadsheet output, which is labelled
    "NOT TO BE SHARED WITH CLIENTS". Its inclusion there was never more than
    accidental, and has become confusing since commit ed48b1da because it is
    now a not-yet-interpreted MST string.
    
    The root cause of the defect is that the authors of the XSL-FO templates
    implemented a state variation of the caption in XSL only, so that the
    caption in non-PDF output had erroneously never reflected the variation.
    Commit ed48b1da merely turned an invisible error into visible confusion.
    
    Arguably this indicates a general defect, and either MST strings in the
    ledger classes should be interpreted before their first possible use, or
    any that might require such interpretation should be allowed only in
    reports that are to be shared with clients.
---
 ledger_text_formats.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ledger_text_formats.cpp b/ledger_text_formats.cpp
index 501ac32..236b08f 100644
--- a/ledger_text_formats.cpp
+++ b/ledger_text_formats.cpp
@@ -470,7 +470,6 @@ void PrintCellTabDelimited
     double total_spec_amt = Invar.InitBaseSpecAmt + Invar.InitTermSpecAmt;
     os << "  Total:\t\t"     << value_cast<std::string>(total_spec_amt) << 
'\n';
     os << "PolicyMktgName\t\t"    << Invar.value_str("PolicyMktgName" ) << 
'\n';
-    os << "PolicyLegalName\t\t"   << Invar.value_str("PolicyLegalName") << 
'\n';
     os << "PolicyForm\t\t"        << Invar.value_str("PolicyForm"     ) << 
'\n';
     os << "UWClass\t\t"           << Invar.value_str("UWClass"        ) << 
'\n';
     os << "UWType\t\t"            << Invar.value_str("UWType"         ) << 
'\n';