lmi-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] valyuta/002 96435be 3/7: Do away with unused return


From: Greg Chicares
Subject: [lmi-commits] [lmi] valyuta/002 96435be 3/7: Do away with unused return value #3
Date: Sun, 20 Sep 2020 18:51:23 -0400 (EDT)

branch: valyuta/002
commit 96435bef4dba22975515f787338d0b9988dcd65a
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Do away with unused return value #3
---
 account_value.hpp | 2 +-
 accountvalue.cpp  | 7 ++-----
 ihs_acctval.cpp   | 7 ++-----
 3 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/account_value.hpp b/account_value.hpp
index b0b6b3b..86041be 100644
--- a/account_value.hpp
+++ b/account_value.hpp
@@ -133,7 +133,7 @@ class LMI_SO AccountValue final
 
     currency RunOneCell            (mcenum_run_basis);
     currency RunOneBasis           (mcenum_run_basis);
-    currency RunAllApplicableBases ();
+    void   RunAllApplicableBases   ();
     void   InitializeLife          (mcenum_run_basis);
     void   FinalizeLife            (mcenum_run_basis);
     void   FinalizeLifeAllBases    ();
diff --git a/accountvalue.cpp b/accountvalue.cpp
index 27fa95b..a936d7c 100644
--- a/accountvalue.cpp
+++ b/accountvalue.cpp
@@ -172,7 +172,7 @@ currency AccountValue::RunOneBasis(mcenum_run_basis 
TheBasis)
 //   if running all bases
 //     run all bases
 //
-currency AccountValue::RunAllApplicableBases()
+void AccountValue::RunAllApplicableBases()
 {
     // set pmts, specamt, surrchg
 
@@ -184,10 +184,9 @@ currency AccountValue::RunAllApplicableBases()
         ,mce_sep_full
         );
 
-    currency z {};
     if(Solving)
         {
-        z = Solve();
+        Solve();
         OverridingPmts = stored_pmts;
         ledger_->SetOneLedgerVariant(run_basis, VariantValues());
         Solving = false;
@@ -205,8 +204,6 @@ currency AccountValue::RunAllApplicableBases()
     run_basis = mce_run_gen_mdpt_sep_full;
     RunOneBasis(run_basis);
     ledger_->SetOneLedgerVariant(run_basis, VariantValues());
-
-    return z;
 }
 
 //============================================================================
diff --git a/ihs_acctval.cpp b/ihs_acctval.cpp
index d450f3e..b23e48e 100644
--- a/ihs_acctval.cpp
+++ b/ihs_acctval.cpp
@@ -262,10 +262,8 @@ currency AccountValue::RunOneBasis(mcenum_run_basis 
a_Basis)
 //   if running all bases
 //     run all bases
 //
-currency AccountValue::RunAllApplicableBases()
+void AccountValue::RunAllApplicableBases()
 {
-    currency z {};
-
     // TODO ?? Normally, running on the current basis determines the
     // overriding values for all components of outlay--e.g., premiums,
     // forceouts, loans, and withdrawals. For a solve on any basis
@@ -290,7 +288,7 @@ currency AccountValue::RunAllApplicableBases()
             RunOneBasis(mce_run_gen_curr_sep_full);
             }
 
-        z = Solve
+        Solve
             (yare_input_.SolveType
             ,yare_input_.SolveBeginYear
             ,yare_input_.SolveEndYear
@@ -309,7 +307,6 @@ currency AccountValue::RunAllApplicableBases()
         {
         RunOneBasis(b);
         }
-    return z;
 }
 
 //============================================================================



reply via email to

[Prev in Thread] Current Thread [Next in Thread]