[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lmi-commits] [lmi] valyuta/004 47b096d 12/17: Fix defect introduced 201
From: |
Greg Chicares |
Subject: |
[lmi-commits] [lmi] valyuta/004 47b096d 12/17: Fix defect introduced 20100723T2339Z: wrong jurisdiction [326] |
Date: |
Thu, 24 Dec 2020 10:23:52 -0500 (EST) |
branch: valyuta/004
commit 47b096d56586320d38066e55ea96e6dfae5f4461
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>
Fix defect introduced 20100723T2339Z: wrong jurisdiction [326]
Commit f6a2418252 incorrectly added this line:
StateOfJurisdiction_ = yare_input_.StateOfJurisdiction;
The LHS had already correctly been initialized from a ctor argument.
The RHS had a hardcoded default value that ignored that argument.
---
ihs_basicval.cpp | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/ihs_basicval.cpp b/ihs_basicval.cpp
index 02bd3e9..52da286 100644
--- a/ihs_basicval.cpp
+++ b/ihs_basicval.cpp
@@ -141,6 +141,7 @@ BasicValues::BasicValues
yare_input_.GroupUnderwritingType = a_UnderwritingBasis ;
yare_input_.ProductName = a_ProductName ;
yare_input_.PremiumTaxState = a_StateOfJurisdiction;
+ yare_input_.StateOfJurisdiction = a_StateOfJurisdiction;
yare_input_.DefinitionOfLifeInsurance = mce_gpt ;
yare_input_.DefinitionOfMaterialChange = mce_adjustment_event ;
@@ -278,12 +279,6 @@ void BasicValues::GPTServerInit()
SetPermanentInvariants();
StateOfDomicile_ = mc_state_from_string(product().datum("InsCoDomicile"));
- // TODO ?? It seems that this assertion should fail sometimes,
- // because StateOfJurisdiction_ is set from a ctor argument that
- // may represent any state, but yare_input_.StateOfJurisdiction
- // is not assigned that value above, and always retains its
- // default value.
- LMI_ASSERT_EQUAL(StateOfJurisdiction_, yare_input_.StateOfJurisdiction);
StateOfJurisdiction_ = yare_input_.StateOfJurisdiction;
PremiumTaxState_ = yare_input_.PremiumTaxState ;
- [lmi-commits] [lmi] valyuta/004 c9b4787 13/17: Make two member functions almost identical, (continued)
- [lmi-commits] [lmi] valyuta/004 c9b4787 13/17: Make two member functions almost identical, Greg Chicares, 2020/12/24
- [lmi-commits] [lmi] valyuta/004 cf62b44 17/17: Record timings, Greg Chicares, 2020/12/24
- [lmi-commits] [lmi] valyuta/004 9d9c2b7 06/17: Assert "length" is same in two classes, Greg Chicares, 2020/12/24
- [lmi-commits] [lmi] valyuta/004 67f1c54 08/17: Move a block of code as just announced, Greg Chicares, 2020/12/24
- [lmi-commits] [lmi] valyuta/004 80a18db 14/17: Make two member functions identical, Greg Chicares, 2020/12/24
- [lmi-commits] [lmi] valyuta/004 89ea7c8 15/17: Change a member's datatype, Greg Chicares, 2020/12/24
- [lmi-commits] [lmi] valyuta/004 c6f6f55 16/17: Expunge a duplicative member function [325], Greg Chicares, 2020/12/24
- [lmi-commits] [lmi] valyuta/004 17275df 05/17: Resolve some more marked defects [326], Greg Chicares, 2020/12/24
- [lmi-commits] [lmi] valyuta/004 72dcc19 11/17: Note an apparent defect [327], Greg Chicares, 2020/12/24
- [lmi-commits] [lmi] valyuta/004 4a21c32 10/17: Move another block of code, Greg Chicares, 2020/12/24
- [lmi-commits] [lmi] valyuta/004 47b096d 12/17: Fix defect introduced 20100723T2339Z: wrong jurisdiction [326],
Greg Chicares <=