[lmi-commits] [lmi] master fabb5a9 5/7: Rewrite (and forbid) defect markers matching 'git grep -w BOOST'

[Greg Chicares]

branch: master
commit fabb5a92964bf90a47db04442f3957097f794809
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Rewrite (and forbid) defect markers matching 'git grep -w BOOST'
---
 expression_template_0_test.cpp |  4 ++--
 global_settings_test.cpp       |  3 ++-
 path_utility.cpp               |  6 +++---
 path_utility_test.cpp          | 10 +++++-----
 test_coding_rules.cpp          |  1 -
 5 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/expression_template_0_test.cpp b/expression_template_0_test.cpp
index eaa3592..cd9697a 100644
--- a/expression_template_0_test.cpp
+++ b/expression_template_0_test.cpp
@@ -22,8 +22,8 @@
 #include "pchfile.hpp"
 
 #if defined TEST_BOOST_UBLAS_TOO
-// BOOST !! Startlingly enough, boost uBLAS depends on this standard
-// macro. If it's not defined, then expression templates aren't used,
+// Startlingly enough, boost uBLAS depends on this standard macro.
+// If it's not defined, then expression templates aren't used,
 // which impairs performance significantly and removes an essential
 // reason for using this library. However, if it is defined, then it
 // must be defined consistently everywhere to avoid ODR problems; but
diff --git a/global_settings_test.cpp b/global_settings_test.cpp
index 7d77ac9..386bb5f 100644
--- a/global_settings_test.cpp
+++ b/global_settings_test.cpp
@@ -44,7 +44,8 @@ void test_directory_exceptions()
         );
 
     // Such string values must be validly-formed paths.
-    // BOOST !! Originally, this test detected that "?" is not a
+    //
+    // SOMEDAY !! boost::filesystem detected that "?" is not a
     // valid directory name, at least for msw. Should that useful
     // validation be regained by adding code to lmi, now that
     // std::filesystem doesn't validate paths semantically? If not,
diff --git a/path_utility.cpp b/path_utility.cpp
index c379ef2..fb07bd5 100644
--- a/path_utility.cpp
+++ b/path_utility.cpp
@@ -270,7 +270,7 @@ fs::path serial_file_path
 /// A try-block is necessary because fs::remove() can throw. The
 /// postcondition is asserted explicitly at the end of the try-block
 /// because the fs::remove() documentation is still unclear:
-///   BOOST !! Is this still true of std::filesystem?
+///   SOMEDAY !! Is this true of std::filesystem as it was of boost?
 /// apparently it mustn't fail without throwing, yet it doesn't throw
 /// on an operation that must fail, like removing a file that's locked
 /// by another process as in the motivating example above.
@@ -347,8 +347,8 @@ void validate_path
 {
     fs::path const path{a_path};
 
-    // BOOST !! This is where well-formedness with respect to OS rules
-    // ought to be tested.
+    // SOMEDAY !! This is where well-formedness with respect to OS
+    // rules ought to be tested, if that is indeed desirable.
 
     if(path.empty())
         {
diff --git a/path_utility_test.cpp b/path_utility_test.cpp
index 3c71337..c955cc2 100644
--- a/path_utility_test.cpp
+++ b/path_utility_test.cpp
@@ -330,7 +330,7 @@ void test_unique_filepath_with_ludicrous_filenames()
     LMI_TEST_EQUAL(path1.string(), "eraseme2");
 
     // "" isn't likely to be a valid filename, but as a path, it's
-    // valid: the boost library's default path ctor constructs an
+    // valid: the boost library's default path ctor constructed an
     // empty path.
 
     fs::path path2 = unique_filepath(fs::path(""), "");
@@ -410,7 +410,7 @@ void test_path_validation()
     validate_filepath("path_utility_test_file", context);
     validate_filepath("./path_utility_test_file", context);
 
-    // BOOST !! With boost::filesystem, a path was not well-formed
+    // SOMEDAY !! With boost::filesystem, a path was not well-formed
     // if it contained forbidden characters. With std::filesystem,
     // semantic validity is not considered, and any syntactically
     // valid path is well formed. Therefore, shouldn't the lmi
@@ -420,7 +420,7 @@ void test_path_validation()
 
 #if 0
     // Neither posix nor msw allows a path to consist solely of NUL.
-    // BOOST !! Fix the 'alarum' problem.
+    // SOMEDAY !! 'alarum' truncates, treating arguments as ASCIIZ.
     std::string nulls = {'\0', '\0'};
     LMI_TEST_THROW
         (validate_filepath(nulls, context)
@@ -436,8 +436,8 @@ void test_path_validation()
     // truncated at the first NUL, due to using std::runtime_error::what(),
     // which returns "char*" string terminated by the first NUL occurring in
     // it, when constructing this message, so just check that it starts with
-    // the expected part. BOOST !! Of course, that's just an expedient
-    // workaround; the defect in 'alarum' needs to be fixed.
+    // the expected part. SOMEDAY !! Of course, that's just an expedient
+    // workaround; the ASCIIZ defect (above) in 'alarum' needs to be fixed.
     LMI_TEST_THROW
         (validate_filepath(with_nulls, context)
         ,std::runtime_error
diff --git a/test_coding_rules.cpp b/test_coding_rules.cpp
index f7e8ff0..a8e5e66 100644
--- a/test_coding_rules.cpp
+++ b/test_coding_rules.cpp
@@ -724,7 +724,6 @@ void check_defect_markers(file const& f)
         bool const error_preceding =
                 true
             &&  "7702 "        != z[1]
-            &&  "BOOST "       != z[1]
             &&  "COMPILER "    != z[1]
             &&  "CURRENCY "    != z[1]
             &&  "DATABASE "    != z[1]