lmi-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lmi-commits] [lmi] master 89e37e40 13/17: Resolve a latent makefile iss


From: Greg Chicares
Subject: [lmi-commits] [lmi] master 89e37e40 13/17: Resolve a latent makefile issue
Date: Sat, 2 Jul 2022 21:42:15 -0400 (EDT)

branch: master
commit 89e37e40923f69a9cf03f4bce5766b4c1af5c7cb
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Resolve a latent makefile issue
    
    A recently-added target-specific value of $(debug_flag) failed to
    propagate through immediately-expanded variables. See:
      https://lists.nongnu.org/archive/html/lmi/2022-07/msg00005.html
    Changed the expansion of the higher-level variables to recursive.
    
    The issue is only latent because everything "works" without this
    revision. The reason is that the '-fno-var-tracking-assignments'
    option that was required with gcc-3.4.5 is no longer necessary.
---
 compiler_clang.make | 4 ++--
 compiler_gcc.make   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/compiler_clang.make b/compiler_clang.make
index df6aa3be..6154adca 100644
--- a/compiler_clang.make
+++ b/compiler_clang.make
@@ -119,7 +119,7 @@ endif
 # are "not required for proper compilation", but lmi supports
 # multiple build types that transcend that "proper" notion.
 
-c_l_flags := $(debug_flag) $(analyzer_flag)
+c_l_flags = $(debug_flag) $(analyzer_flag)
 
 ifeq (x86_64-pc-linux-gnu,$(LMI_TRIPLET))
   c_l_flags += -fPIC
@@ -130,7 +130,7 @@ endif
 # clang-14.0.5-1 doesn't need all this rigmarole--see:
 #   https://lists.nongnu.org/archive/html/lmi/2022-06/msg00072.html
 
-REQUIRED_COMPILER_FLAGS := \
+REQUIRED_COMPILER_FLAGS = \
   $(c_l_flags) \
   -Woverriding-t-option \
     -ffp-model=strict \
diff --git a/compiler_gcc.make b/compiler_gcc.make
index 976f9d07..946760b1 100644
--- a/compiler_gcc.make
+++ b/compiler_gcc.make
@@ -182,7 +182,7 @@ $(product_file_sources): optimization_flag += -Os
 # are "not required for proper compilation", but lmi supports
 # multiple build types that transcend that "proper" notion.
 
-c_l_flags := $(debug_flag) $(analyzer_flag)
+c_l_flags = $(debug_flag) $(analyzer_flag)
 
 ifeq (x86_64-pc-linux-gnu,$(LMI_TRIPLET))
   c_l_flags += -fPIC
@@ -205,7 +205,7 @@ endif
 # which causes harm while bringing no countervailing benefit--see:
 #   https://lists.nongnu.org/archive/html/lmi/2017-08/msg00045.html
 
-REQUIRED_COMPILER_FLAGS := \
+REQUIRED_COMPILER_FLAGS = \
   $(c_l_flags) \
   -frounding-math \
   -fsignaling-nans \



reply via email to

[Prev in Thread] Current Thread [Next in Thread]