[lmi-commits] [lmi] master 89930e76 15/24: Experimentally work around a clang warning

[Greg Chicares]

branch: master
commit 89930e763a13cd59bcdeba027a8952afd1473ee9
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Experimentally work around a clang warning
    
    * compiler_clang_warnings.make: Enabled '-Wunneeded-member-function'.
    * pdf_command_wx.cpp: This was the only instance of this warning.
      Removing the dtor elicited a warning that a virtual dtor is needed.
      Making it virtual made the warning go away. The change seems good
      because the class has virtual members, so the dtor should be virtual.
---
 compiler_clang_warnings.make | 1 -
 pdf_command_wx.cpp           | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/compiler_clang_warnings.make b/compiler_clang_warnings.make
index 90314de3..97a19726 100644
--- a/compiler_clang_warnings.make
+++ b/compiler_clang_warnings.make
@@ -87,7 +87,6 @@ clang_cxx_warnings := \
   -Wno-sign-conversion \
   -Wno-string-plus-int \
   -Wno-undefined-func-template \
-  -Wno-unneeded-member-function \
   -Wno-unreachable-code-break \
   -Wno-weak-template-vtables \
   -Wno-weak-vtables \
diff --git a/pdf_command_wx.cpp b/pdf_command_wx.cpp
index f3e11749..6524a646 100644
--- a/pdf_command_wx.cpp
+++ b/pdf_command_wx.cpp
@@ -360,7 +360,7 @@ class table_mixin
     {
     }
 
-    ~table_mixin() = default;
+    virtual ~table_mixin() = default;
 
     // Description of a single table column.
     struct illustration_table_column