[lmi-commits] [lmi] master c21d8849 12/24: Explain why certain clang warnings will remain disabled

[Greg Chicares]

branch: master
commit c21d8849fc20ae27f3c989cd743be74de5f55a58
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Explain why certain clang warnings will remain disabled
---
 compiler_clang_warnings.make | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/compiler_clang_warnings.make b/compiler_clang_warnings.make
index 6244f074..91c8c049 100644
--- a/compiler_clang_warnings.make
+++ b/compiler_clang_warnings.make
@@ -48,6 +48,9 @@ clang_c_warnings := \
 # Write '-Wno' options at the end, with a rationale here.
 #
 # -Wstring-plus-int: false negatives and no true positives in lmi.
+# -Wunreachable-code-break: pleonastic 'break' adds clarity.
+# -Wweak-template-vtables: same as '-Wweak-vtables'.
+# -Wweak-vtables: it's better to let the linker remove duplicates.
 
 clang_cxx_warnings := \
   $(clang_common_warnings) \
@@ -86,14 +89,11 @@ clang_cxx_warnings := \
   -Wno-undefined-func-template \
   -Wno-unknown-pragmas \
   -Wno-unneeded-member-function \
-  -Wno-unreachable-code \
   -Wno-unreachable-code-break \
-  -Wno-unreachable-code-return \
   -Wno-unused-macros \
   -Wno-unused-template \
   -Wno-weak-template-vtables \
   -Wno-weak-vtables \
-  -Wno-zero-as-null-pointer-constant \
 
 # Target-specific modifications.