[lmi-commits] [lmi] odd/abstract_base 6e57d92b 2/3: Make a class that's intended to be abstract actually abstract

[Greg Chicares]

branch: odd/abstract_base
commit 6e57d92ba7683527c3e80498f8155caa442d8e22
Author: Gregory W. Chicares <gchicares@sbcglobal.net>
Commit: Gregory W. Chicares <gchicares@sbcglobal.net>

    Make a class that's intended to be abstract actually abstract
    
    The leading comment for class datum_sequence has long said:
      /// Abstract base class for MVC input sequences.
    C++20 [class.abstract] says "A class is an abstract class if it has at
    least one pure virtual function", but this class had none.
---
 datum_sequence.hpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/datum_sequence.hpp b/datum_sequence.hpp
index eb7cd644..9f8b8cfc 100644
--- a/datum_sequence.hpp
+++ b/datum_sequence.hpp
@@ -74,7 +74,7 @@ class datum_sequence
     datum_sequence(datum_sequence&&) = default;
     datum_sequence& operator=(datum_sequence const&) = default;
     datum_sequence& operator=(datum_sequence&&) = default;
-    ~datum_sequence() override = default;
+    ~datum_sequence() override = 0;
 
     datum_sequence& operator=(std::string const&);
 
@@ -88,6 +88,8 @@ class datum_sequence
     bool keyword_values_are_blocked_;
 };
 
+inline datum_sequence::~datum_sequence() = default;
+
 bool operator==(datum_sequence const&, datum_sequence const&);
 
 // Specialize value_cast<> for each derived class, e.g., as follows: