Re: [lmi] [lmi-commits] master 0b00d05 1/4: Use C++17 static inline variable initialization

[Greg Chicares]

On 2018-09-18 00:56, Vadim Zeitlin wrote:
> On Mon, 17 Sep 2018 20:48:32 -0400 (EDT) Greg Chicares <address@hidden> wrote:
[...]
> GC> +    // "-1" is invalid; use start_numbering() to change it.
> GC> +    static inline int last_page_number_ = {-1};
> GC> +    int               this_page_number_ = {0};
> GC> +    int               extra_pages_      = {0};
> GC>  };
> 
>  And didn't we also decide to standardize on "extra_pages_{0}", i.e. should
> the equal signs be really used here?

Let me again consult 'input_sequence_parser.hpp' to see the One True Way:

    duration_mode previous_duration_scalar_mode_ {e_inception};
    duration_mode current_duration_scalar_mode_  {e_inception};
    ValueInterval current_interval_              {};

Oops. I'll fix this. We want our initialization to be uniformly uniform.

>  Sorry for these trivial comments, but after spending so much time on
> replacing parenthesis with braces I'd like to avoid having to do it again
> in the observable future...

Uniformity matters a great deal to me. Thanks for catching it before I
spread it throughout this translation unit.