lmi
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lmi] [lmi-commits] master 8862ffc 7/9: Improve const correctness


From: Greg Chicares
Subject: Re: [lmi] [lmi-commits] master 8862ffc 7/9: Improve const correctness
Date: Thu, 13 Jun 2019 18:14:56 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

On 2019-06-13 00:40, Vadim Zeitlin wrote:
> On Thu, 13 Jun 2019 00:00:48 +0000 Greg Chicares <address@hidden> wrote:
[...]
> GC> The lines exceed eighty characters, so they're too long already.
> [...]
> GC> This thing is regrettably metastable, but I can't think of a good way
> GC> to change it again without making it worse.
> 
>  The only suggestion I have here is to implement them outside of the class,
> on multiple lines. I guess you don't want to have multiple lines inside the
> class declaration because it would make the class synopsis less obvious,
> but this consideration doesn't apply if you put them outside of it, does
> it?

I'm always trying to make as much code as possible fit on one screen,
and my screen is small. Rewriting six member functions out of line
would spoil the compactness.

Anyway, further modifications to this file yield diminishing returns,
so I decided to walk away from it and commit Ilya's MVC improvements
instead.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]