Re: [lmi] [lmi-commits] master 3a5c416d 5/6: Reenable a warning and resolve its cause

[Vadim Zeitlin]

On Wed, 29 Jun 2022 11:11:35 -0400 (EDT) Greg Chicares 
<gchicares@sbcglobal.net> wrote:

GC> branch: master
GC> commit 3a5c416d4e200ab638862570341bd1d6fdce197e
GC> Author: Gregory W. Chicares <gchicares@sbcglobal.net>
GC> Commit: Gregory W. Chicares <gchicares@sbcglobal.net>
GC> 
GC>     Reenable a warning and resolve its cause
GC>     
GC>     In cases like this:
GC>       location_info(line_num, current - start + 1)
GC>     the second argument is a pointer difference, but its type was 'int'.
GC>     Changing the type to 'long int' would work for LP64, but 'long long int'
GC>     is needed for LLP64.

 Unfortunately the original history was lost, so I don't know if I gave any
rationale for using int here in the commit message adding it, but right now
I can't think of any reason for not using ptrdiff_t here. Shouldn't we just
do this, instead?

 BTW, there are also a number of bourn_cast<>s that should have become
unnecessary now (and would also be unnecessary if we used ptrdiff_t).

 Sorry if you already planned to change this/remove them and I was just too
impatient,
VZ

pgp4yavGl2poT.pgp
Description: PGP signature