Re: [lmi] PreviewFrameEx questions

[Vadim Zeitlin]

On Wed, 27 Jul 2022 21:10:53 +0000 Greg Chicares <gchicares@sbcglobal.net> 
wrote:

GC> On 5/19/22 15:13, Vadim Zeitlin wrote:
GC> [...]
GC> >  Please let me know what, if anything, should I do about these 2 problems
GC> > (and IMO both of them are actual UI problems, especially the first one,
GC> > even if the only reason I noticed them was due to looking for the "WX !!"
GC> > comments in the code).
GC> 
GC> I really don't want to touch this code.

 That's fine, of course, but shouldn't we just remove it if nobody uses it
then?

GC> I don't use "print preview" myself, and I'm not even sure I can.
GC> IIRC, this facility uses a mime-type to figure out how to display
GC> a preview. My chroots have no pdf viewer; my "host" system does,
GC> but not the chroots. Thus, when I try "File | Print preview", I see:
GC> 
GC> 0048:fixme:imm:ImeSetActiveContext (0x257fd0, 0): stub
GC> 0048:fixme:imm:ImmReleaseContext (0000000000010020, 0000000000257FD0): stub
GC> 0024:fixme:imm:ImeSetActiveContext (0x269f40, 1): stub
GC> 0024:fixme:imm:ImmReleaseContext (0000000000010056, 0000000000269F40): stub
GC> 0024:fixme:shell:IQueryAssociations_fnGetString assocstr 7 unimplemented!
GC> In file /opt/lmi/src/lmi/third_party/wx/src/msw/mimetype.cpp at line 287: 
'AssocQueryString' failed with error 0x80004001 (Not implemented.).
GC> 0024:fixme:shell:IQueryAssociations_fnGetString assocstr 10 unimplemented!
GC> In file /opt/lmi/src/lmi/third_party/wx/src/msw/mimetype.cpp at line 287: 
'AssocQueryString' failed with error 0x80004001 (Not implemented.).
GC> 00fc:err:winebrowser:launch_app could not find a suitable app to open 
L"file:///opt/lmi/print/unnamed1.pdf"

 This is a Wine-specific problem, any native MSW system will be able to
open the PDF file in its default associated application. In fact, I know
for a fact that latest Windows versions associate PDF with the (always
installed) Edge browser because its (or, rather, Chrome, which it's based
on) developers have managed to introduce a bug preventing the properly
written applications from working with it, while trying to accommodate some
broken ones (see https://github.com/wxWidgets/wxWidgets/issues/22618 for
more details if you're curious).

GC> And I'm not sure whether end users ever use this facility.

 As an alternative to removing it, what about disabling it in one release
and seeing if anybody complains? If nobody does, it would seem to be that
nobody would regret it being removed neither...

 Regards,
VZ

pgphXos7_mxpu.pgp
Description: PGP signature