[lwip-commits] [SCM] UNNAMED PROJECT branch, ppp-new, updated. 3fd7bc8058bb726c1aa0ddb965b36aabb685286c

[Sylvain Rochet]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".

The branch, ppp-new has been updated
       via  3fd7bc8058bb726c1aa0ddb965b36aabb685286c (commit)
       via  25e398a8f0184c4342d02b43a9032ac6fc865235 (commit)
       via  c31b03327f4ee4307ce97db5bfddb592c5d83fe3 (commit)
       via  f6d56e29378c4e10d7b0a3d576044cff49c94fe0 (commit)
      from  ca7769e041efb410eafe02ee3a028e200b00fb31 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3fd7bc8058bb726c1aa0ddb965b36aabb685286c
Author: Sylvain Rochet <address@hidden>
Date:   Tue Apr 15 22:57:59 2014 +0200

    PPP, updated pppd followup

commit 25e398a8f0184c4342d02b43a9032ac6fc865235
Author: Sylvain Rochet <address@hidden>
Date:   Tue Apr 15 22:55:28 2014 +0200

    PPP, from PPPD upstream, accept IPCP ConfAck packets containing MS-WINS 
options
    
    pppd: Accept IPCP ConfAck packets containing MS-WINS options
    
    Since last week I'm seeing IPCP negotiations going like this (and
    eventually failing) when connecting to my ISP:
    
    Jul 11 20:03:25 * pppd[4833]: sent [IPCP ConfReq id=0x2 <addr 0.0.0.0> 
<ms-dns1
    0.0.0.0> <ms-dns2 0.0.0.0>]
    Jul 11 20:03:26 * pppd[4833]: sent [IPCP ConfReq id=0x2 <addr 0.0.0.0> 
<ms-dns1
    0.0.0.0> <ms-dns2 0.0.0.0>]
    Jul 11 20:03:26 * pppd[4833]: rcvd [IPCP ConfNak id=0x2 <addr 
10.167.246.198>
    <ms-dns1 213.162.69.1> <ms-dns2 213.162.69.169> <ms-wins 124.6.168.55> 
<ms-wins
    17.17.17.17>]
    Jul 11 20:03:26 * pppd[4833]: sent [IPCP ConfReq id=0x3 <addr 
10.167.246.198>
    <ms-dns1 213.162.69.1> <ms-dns2 213.162.69.169> <ms-wins 124.6.168.55> 
<ms-wins
    17.17.17.17>]
    Jul 11 20:03:26 * pppd[4833]: rcvd [IPCP ConfAck id=0x3 <addr 
10.167.246.198>
    <ms-dns1 213.162.69.1> <ms-dns2 213.162.69.169> <ms-wins 124.6.168.55> 
<ms-wins
    17.17.17.17>]
    Jul 11 20:03:27 * pppd[4833]: sent [IPCP ConfReq id=0x3 <addr 
10.167.246.198>
    <ms-dns1 213.162.69.1> <ms-dns2 213.162.69.169> <ms-wins 124.6.168.55> 
<ms-wins
    17.17.17.17>]
    ...
    
    with the last two lines repeating until the IPCP error limit is
    reached. As you can see, the peer added two extra fields in the
    ConfNak reply. This is allowed, and indeed the following sent
    ConfReq packet reflects this. However, when the ConfAck packet
    is received, pppd discards it as invalid, because of the ms-wins
    fields.
    
    This fixes it.

commit c31b03327f4ee4307ce97db5bfddb592c5d83fe3
Author: Sylvain Rochet <address@hidden>
Date:   Tue Apr 15 22:50:53 2014 +0200

    PPP, from PPPD upstream, Don't crash if NULL pointer passed to vslprintf 
for %q or %v
    
    pppd: Don't crash if NULL pointer passed to vslprintf for %q or %v
    
    This is to avoid crashes like that reported in
    https://bugs.launchpad.net/ubuntu/+source/ppp/+bug/1244714

commit f6d56e29378c4e10d7b0a3d576044cff49c94fe0
Author: Sylvain Rochet <address@hidden>
Date:   Tue Apr 15 22:34:24 2014 +0200

    PPP, from PPPD upstream, take out unused %r conversion completely,
    
    pppd: Take out unused %r conversion completely
    
    This just removes some code surrounded by #if 0/#endif, which Fedora
    apparently feels the need to patch...

-----------------------------------------------------------------------

Summary of changes:
 src/netif/ppp/PPPD_FOLLOWUP |  146 ++++++++++++++++++++++++++++++++++++++++++-
 src/netif/ppp/ipcp.c        |   19 ++++++
 src/netif/ppp/utils.c       |   15 +----
 3 files changed, 166 insertions(+), 14 deletions(-)


hooks/post-receive
-- 
UNNAMED PROJECT