Re: [lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, updated. e77e18f8c4108cd10a50a87d87158d63bdb9bc3b

[Sylvain Rochet]

Hello Simon,

On Mon, Apr 13, 2015 at 09:54:46PM +0200, Sylvain Rochet wrote:
> Hello Simon,
> 
> On Mon, Apr 13, 2015 at 07:24:50PM +0000, Simon Goldschmidt wrote:
> > 
> >     Worked on IPv6-only stack:
> >     - prepared DNS;
> >     - fixed compiling ppp.c
> 
> I'm not sure that's correct LWIP_IPV4 and PPP_IPV4_SUPPORT are 
> orthogonal.
> 
> #if PPP_IPV4_SUPPORT
> static err_t ppp_netif_output_ip4(struct netif *netif, struct pbuf *pb, const 
> ip4_addr_t *ipaddr);
> #endif /* PPP_IPV4_SUPPORT */
> 
> #if PPP_IPV4_SUPPORT
> /* FIXME: change that when netif_null_output_ip4() will materialize */
> netif->output = ppp_netif_output_ip4;
> #endif /* PPP_IPV4_SUPPORT */
> 
> Should be LWIP_IPV4 instead of PPP_IPV4_SUPPORT isn't it ?

I am not clear.

We don't have (yet?) a netif_null_output_ip4() by default like we have 
for IPv6 with netif_null_output_ip6(), so, if LWIP_IPV4 is true but 
PPP_IPV4_SUPPORT is false, we need a dummy ppp_netif_output_ip4() 
function.

Sylvain

signature.asc
Description: Digital signature