lwip-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, up


From: Sylvain Rochet
Subject: [lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, updated. c4d78e642206761d12dfa594f79afe2920756c4b
Date: Wed, 20 Jan 2016 20:19:59 +0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "lwIP - A Lightweight TCPIP stack".

The branch, master has been updated
       via  c4d78e642206761d12dfa594f79afe2920756c4b (commit)
       via  52463fa25b568c16aebc07555fcdd8be1b1c4bfb (commit)
      from  96373f6959893109ad074be68b0fe1049099c2e5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c4d78e642206761d12dfa594f79afe2920756c4b
Author: Sylvain Rochet <address@hidden>
Date:   Wed Jan 20 21:12:37 2016 +0100

    PPP, PPPoL2TP, fix double free of L2TP pcb in pppol2tp_create error path
    
    ppp_free() calls the low level protocol destroy function, pppol2tp_destroy()
    here, which freed the l2tp pcb, followed by pppol2tp_create which also freed
    the pcb.
    
    Fixing it by reordering the L2TP init so we don't have to call ppp_free()
    anymore.
    
    Signed-off-by: Sylvain Rochet <address@hidden>

commit 52463fa25b568c16aebc07555fcdd8be1b1c4bfb
Author: Wayne Uroda <address@hidden>
Date:   Wed Jan 20 20:50:08 2016 +0100

    PPP, PPPoS, fix dereference of uninitialised pppos->in_head pointer
    
    When I create a new PPP connection, I am seeing a hardfault (segfault)
    coming from pbuf_free.
    
    I traced the problem to an invalid in_head field of the pppos_pcb structure.
    The field is invalid because the memory is never cleared to zero after the
    pppos_pcb structure is created in pppos_create().
    
    I was able to fix the issue by adding a memset after the memp_malloc call.
    
    Signed-off-by: Sylvain Rochet <address@hidden>

-----------------------------------------------------------------------

Summary of changes:
 src/netif/ppp/pppol2tp.c |   14 +++++++-------
 src/netif/ppp/pppos.c    |    1 +
 2 files changed, 8 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
lwIP - A Lightweight TCPIP stack



reply via email to

[Prev in Thread] Current Thread [Next in Thread]