[lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, updated. master_at_STABLE-2_0_0-55-gbcaf2f0

[Sylvain Rochet]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "lwIP - A Lightweight TCPIP stack".

The branch, master has been updated
       via  bcaf2f08aab5f86d384ffe96a09755ac1b8bd210 (commit)
      from  4bbed75cc478a142e0f6a28d2176c6d91fcea863 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit bcaf2f08aab5f86d384ffe96a09755ac1b8bd210
Author: Sylvain Rochet <address@hidden>
Date:   Wed Nov 30 21:56:27 2016 +0100

    PPP, PPPoS: fix memory leak when disconnecting if there are remaining input 
bytes
    
    Art says:
      pppos_input() can call ppp_input() which can call pppos_disconnect() to
      disconnect the interface.  However, it will continue to read in
      characters and allocate a pbuf from the PBUF_POOL and keep it in
      pppos->in_head and in_tail. When a re-connect happens and pppos_connect()
      is called, this pppos->in_head and in_tail are zeroed, hence a memory
      leak. (This happens with PPP_INPROC_IRQ_SAFE not defined.)
    
      A fix would be inside pppos_input() to break out of the loop inputting
      characters after calling ppp_input() if pppos->open == 0.  Note that
      the loop is not even entered if pppos->open == 0.
    
              ppp_input(ppp, inp);
              if(pppos->open == 0) //get out if they disconnected
                break;
    
    Fix it in a similar way which doesn't add new code by moving the
    existing pppos->open check inside the byte loop.

-----------------------------------------------------------------------

Summary of changes:
 src/netif/ppp/pppos.c |   16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)


hooks/post-receive
-- 
lwIP - A Lightweight TCPIP stack