[lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, updated. master_at_STABLE-2_0_0-542-gc722261

[Joel Cunningham]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "lwIP - A Lightweight TCPIP stack".

The branch, master has been updated
       via  c72226114279adb7b5696c49913624add1dc1f33 (commit)
      from  720f9b3a0b027c7876748905273978dd159feedf (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c72226114279adb7b5696c49913624add1dc1f33
Author: Joel Cunningham <address@hidden>
Date:   Wed Mar 22 16:19:23 2017 -0500

    tcp: bug #50614: move unsent queue check/pcb->snd_buf update
    
    This commit corrects what looks like an ancient incorrect organization
    of the logic for processing an ACK which acks new data.  Once moved,
    we can also change to using TCP_SEQ_LEQ on ackno instead of TCP_BETWEEN
    because ackno has already been checked against snd_nxt
    
    The work of checking the unsent queue and updating pcb->snd_buf (both
    steps required for new data ACK) should be located under the conditional
    that checks TCP_SEQ_BETWEEN(ackno, pcb->lastack+1, pcb->snd_nxt)
    
    The comment following the unsent queue check/pcb->snd_buf update even
    indicates "End of ACK for new data processing" when the logic is clearly
    outside of this check
    
    From what I can tell, this mis-organization isn't causing any incorrect
    behavior since the unsent queue checked that ackno was between start of
    segment and snd_nxt and recv_acked would be 0 during pcb->snd_buf update.
    Instead this is waisted work for duplicate ACKS (can be common) and other
    old ACKs

-----------------------------------------------------------------------

Summary of changes:
 src/core/tcp_in.c | 68 +++++++++++++++++++++++++++----------------------------
 1 file changed, 34 insertions(+), 34 deletions(-)


hooks/post-receive
-- 
lwIP - A Lightweight TCPIP stack