Re: [lwip-commits] [SCM] lwIP - A Lightweight TCPIP stack branch, master, updated. master_at_STABLE-2_0_0-990-gcf07fdd

[address@hidden]

Joel Cunningham wrote:
> There seems to be varying usage of SYS_ARCH_PROTECT() around calls 
> to tryget_socket_unconn() and tryget_socket_unconn_nouse().  What 
> cases should those calls be protected?  At first, I thought maybe 
> tryget_socket_unconn() always required SYS_ARCH_PROTECT due to 
> incrementing the socket used counter, but sock_inc_used() is already 
> internally uses SYS_ARCH_PROTECT

tryget_socket_unconn() must be called protected or there would be a race 
between tryget_socket_unconn_nouse() returning a socket and calling 
sock_inc_used(ret). It's true that in this case, the latter wouldn't 
need protection itself...

Looking through the code, there *is* a race condition when called from 
get_socket(), which always seems to be called unlocked. I'll file a bug 
for this.

Simon