[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lwip-users] LLDP Implementation for 1.4.1
From: |
Simon Goldschmidt |
Subject: |
Re: [lwip-users] LLDP Implementation for 1.4.1 |
Date: |
Mon, 14 Nov 2016 09:52:33 +0100 |
Amit Ashara wrote:
> [..] The function that the receive performs is highly varied based on the
> context of the TLV.
That's also true for transmission. E.g. going back to the profinet case, there
are numerous other
things to send. You'd need to find a way to make sending configurable to make
it useful for
the non-standard-IT case...
Other than that:
- please diff against newer sources (git master, 2.0.0)
- indentation = 2 spaces, not 4
- no need to change opt.h/stats.h, such deep integration is neither wanted nor
needed for 3rd party protocols
- don't use heap allocation just to fill in a TLV: this is for embedded
systems, right?
- separate protocol definitions from external interface of the component (not
everything in one header)
- keep private functions "static" in the C file
- etc...?
And last but not least, I have to repeate myself: if you want this to be
integrated into core lwIP,
open a patch tracker entry for it on savannah and put the sources there.
Simon
- Re: [lwip-users] LLDP Implementation for 1.4.1, Amit Ashara, 2016/11/02
- Re: [lwip-users] LLDP Implementation for 1.4.1, Simon Goldschmidt, 2016/11/02
- Re: [lwip-users] LLDP Implementation for 1.4.1, Amit Ashara, 2016/11/02
- Re: [lwip-users] LLDP Implementation for 1.4.1, Amit Ashara, 2016/11/02
- Re: [lwip-users] LLDP Implementation for 1.4.1, Amit Ashara, 2016/11/05
- Re: [lwip-users] LLDP Implementation for 1.4.1, Amit Ashara, 2016/11/11
- Re: [lwip-users] LLDP Implementation for 1.4.1, Dirk Ziegelmeier, 2016/11/12
- Re: [lwip-users] LLDP Implementation for 1.4.1, Amit Ashara, 2016/11/12
- Re: [lwip-users] LLDP Implementation for 1.4.1,
Simon Goldschmidt <=
- Re: [lwip-users] LLDP Implementation for 1.4.1, Amit Ashara, 2016/11/15