[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: lynx-dev source syntax highlighting patch
From: |
Leonid Pauzner |
Subject: |
Re: lynx-dev source syntax highlighting patch |
Date: |
Mon, 29 Mar 1999 15:53:53 +0400 (MSD) |
26-Mar-99 16:14 Vlad Harchev wrote:
> On Mon, 29 Mar 1999, Leonid Pauzner wrote:
>> 25-Mar-99 22:59 Vlad Harchev wrote:
>> > Here is a big patch (~165Kb unzipped!) that will:
>> > * Added HTML source syntax highlighting (when option -prettysrc that is
>> > added
>> >[...]
>>
>> At least this looks wrong
>> - unnecesary complication in SGML.c/handle_entities() -
>> it should be an obvious substitution of "entity_string"
>> possible coloured differently depending on FoundEntity value.
>>
> Yes, in SGML.c:handle_entity it may be will be better to remove anything
> in the
> if (psrc_view) {
> /* contents should be removed */
> }
> leaving the only
> if (psrc_view) {
> }
> conditionals, and draw the entity_string in the caller of handle_entity
right.
> according to the value of the FoundEntity. If you mean something else, please
> describe it more thoroughly.
> Frankly speaking, when modifying SGML.c, I was working in character-device
> -mode: I din't look any page forward - I was modifying "inplace". But it
SGML_character is hardly maintainable and you trying to add a bit more
without a special care, please keep this in mind.
> works OK- I've tested it extensively. The files in /test are good testsuite
> for it.