Re: [Lynx-dev] [PATCH] correction for symlink brokenness in lists

[Thomas Dickey]

On Thu, Mar 11, 2004 at 11:17:03PM -0800, Kees Cook wrote:
> Hello!  Looks like behavior changed between 2.8.4 and 2.8.5 when doing 
> listings of local directories ("lynx .")
> 
> In 2.8.4, symlinks would be sorted based on their _destination_ file 
> type (symlinks to dirs go into "Subdirectories", symlinks to files go to 
> "Files").
> 
> It looks like during cleanups the top-level "stat" turned into an 
> "lstat", which breaks the S_ISDIR test that would correctly sort the 
> symlink into the Subdirectories list.
> 
> I have delayed the "lstat" call, and instead, use just plain "stat" 
> again at the top, and only do an "lstat" call once we get to determining 
> if the file really is a symlink or not.

thanks.  I probably broke this as a side-effect of

2001-11-18 (2.8.5dev.5)
* modify dired support to allow sorting by a variety of things in addition to
  the existing sort into files versus directories.  This is saved in ~/lynxrc
  as dir_sort_order -TD

-- 
Thomas E. Dickey
http://invisible-island.net
ftp://invisible-island.net

pgpRqhstiEIdL.pgp
Description: PGP signature

_______________________________________________
Lynx-dev mailing list
address@hidden
http://mail.gnu.org/mailman/listinfo/lynx-dev