[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: FYI: 16-gary-refactor-symbol-api.patch
From: |
Akim Demaille |
Subject: |
Re: FYI: 16-gary-refactor-symbol-api.patch |
Date: |
Thu, 26 Jun 2003 11:36:54 +0200 |
User-agent: |
Gnus/5.1002 (Gnus v5.10.2) Emacs/21.3 (gnu/linux) |
> - switch (VALUE_TYPE (argv[i]))
> + if (m4_is_symbol_value_text (argv[i]))
> {
> - case M4_SYMBOL_TEXT:
> m4_trace_format ("%l%S%r", M4ARG (i));
> - break;
> -
> - case M4_SYMBOL_FUNC:
> - bp = m4_builtin_find_by_func (NULL, VALUE_FUNC (argv[i]));
> + }
> + else if (m4_is_symbol_value_func (argv[i]))
> + {
> + bp = m4_builtin_find_by_func (NULL,
> + m4_get_symbol_value_func(argv[i]));
> if (bp == NULL)
> {
> M4ERROR ((warning_status, 0, "\
Wow, this is a pity. I did not understand the rationale very well
here, but since I considering adding some more object types, I
appreciated having a enum-like handling.
Anyway, congrats on the refactoring, your work is impressive.