m4-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

gentoo bug 259184 - spurious testsuite failure


From: Eric Blake
Subject: gentoo bug 259184 - spurious testsuite failure
Date: Mon, 16 Feb 2009 22:41:27 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

http://bugs.gentoo.org/show_bug.cgi?id=259184

reports a failure where the testsuite expects ENOENT, but hardening root means 
it gets EACCES instead.  Since the access is denied either way, and m4 detects 
the failure at opening the impossible path, the bug is in the testsuite for not 
being tolerant to the spelling in the error message.  Fixing as follows:


From: Eric Blake <address@hidden>
Date: Mon, 16 Feb 2009 15:37:32 -0700
Subject: [PATCH] Avoid test failure due to different errno.

* doc/m4.texinfo (Using frozen files): Ignore stdout, since
hardened systems can prevent attempts to read /.
* THANKS: Update.
Reported by Ronny Peine, in Gentoo bug 259184.

Signed-off-by: Eric Blake <address@hidden>
---
 ChangeLog      |    6 ++++++
 THANKS         |    1 +
 doc/m4.texinfo |    2 ++
 3 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index e546cd6..0176fe4 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2009-02-16  Eric Blake  <address@hidden>

+       Avoid test failure due to different errno.
+       * doc/m4.texinfo (Using frozen files): Ignore stdout, since
+       hardened systems can prevent attempts to read /.
+       * THANKS: Update.
+       Reported by Ronny Peine, in Gentoo bug 259184.
+
        Avoid tests that make no sense, because m4 is single-threaded.
        * m4/gnulib-cache.m4: Avoid lock-tests and tls-tests.

diff --git a/THANKS b/THANKS
index 45cad18..fcbad32 100644
--- a/THANKS
+++ b/THANKS
diff --git a/doc/m4.texinfo b/doc/m4.texinfo
index 9bbfcfd..08daafe 100644
--- a/doc/m4.texinfo
+++ b/doc/m4.texinfo
@@ -7097,8 +7097,10 @@ Using frozen files
 @end example

 @c Detect inability to freeze.
address@hidden Some systems harden /, and fail with EACCES rather than ENOENT.

 @comment options: -F /none/such
address@hidden xerr: ignore
 @comment status: 1
 @example
 $ @kbd{m4 -F /none/such}
-- 
1.6.1.2







reply via email to

[Prev in Thread] Current Thread [Next in Thread]