[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Long option for -W (--word-regexp) accepted without ENABLE_CHANGEWOR
|
From: |
Eric Blake |
|
Subject: |
Re: Long option for -W (--word-regexp) accepted without ENABLE_CHANGEWORD defined |
|
Date: |
Wed, 05 Feb 2014 13:19:05 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
On 02/05/2014 06:58 AM, Vitezslav Crhonek wrote:
> Hello,
>
> small issue I've found today, here's the fix:
>
> --- m4-1.4.17/src/m4.c.orig 2013-09-22 07:50:43.000000000 +0200
> +++ m4-1.4.17/src/m4.c 2014-02-05 14:49:06.706025544 +0100
> @@ -307,7 +307,9 @@
> {"trace", required_argument, NULL, 't'},
> {"traditional", no_argument, NULL, 'G'},
> {"undefine", required_argument, NULL, 'U'},
> +#ifdef ENABLE_CHANGEWORD
> {"word-regexp", required_argument, NULL, 'W'},
> +#endif
Indeed the correct fix. The problem isn't completely bad, just a poor
error message:
$ m4 -W
m4: invalid option -- 'W'
Try `m4 --help' for more information.
$ m4 --word-regexp=
Try `m4 --help' for more information.
and with your patch:
$ src/m4 --word-regexp=
src/m4: unrecognized option '--word-regexp='
Try `src/m4 --help' for more information.
I added a changelog entry (the 'tiny change' marker explains we did not
need copyright papers) and pushed the patch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature