[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Man-db-devel] [PATCH] src/tests: Use /tmp for temprorary directorie
From: |
Colin Watson |
Subject: |
Re: [Man-db-devel] [PATCH] src/tests: Use /tmp for temprorary directories |
Date: |
Fri, 9 Dec 2016 21:36:13 +0000 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Dec 07, 2016 at 04:08:49AM +0500, Mihail Konev wrote:
> Reduces disk reads/writes made by 'make check -C src'.
I'm in favour of this in principle, but:
> diff --git a/src/tests/testlib.sh b/src/tests/testlib.sh
> index d8fbc6ca07d3..78b81713662f 100644
> --- a/src/tests/testlib.sh
> +++ b/src/tests/testlib.sh
> @@ -8,10 +8,10 @@ MAN_TEST_DISABLE_SYSTEM_CONFIG=1
> export MAN_TEST_DISABLE_SYSTEM_CONFIG
>
> init () {
> - tmpdir="tmp-${0##*/}"
> + tmpdir=$(mktemp -d)
As far as I know, and this is supported by the Autoconf documentation,
mktemp is not available on all systems. Could you please rework this a
bit so that it falls back to the previous "tmp-${0##*/}" value if mktemp
is unavailable (or indeed possibly is available but doesn't support the
-d option)?
The Autoconf docs have sample code for this; that uses $TMPDIR and
$RANDOM, but it would be easy to adjust it to match man-db's previous
behaviour.
Thanks,
--
Colin Watson address@hidden