Re: [MIT-Scheme-devel] Fixes pushed

[Chris Hanson]

Thanks!

Fixed both bugs.

On Mon, Feb 29, 2016 at 10:51 PM, <address@hidden> wrote:

Hello Chris!

One more, commit 69e6107c introduced optional parameters #!optional
start to vector-fill!, but end was overlooked (even though used in the
function).
I'd suggest the following:

diff --git a/src/runtime/vector.scm b/src/runtime/vector.scm
index 75baafb..90b4319 100644
--- a/src/runtime/vector.scm
+++ b/src/runtime/vector.scm
@@ -68,7 +68,7 @@ USA.
                   (if (default-object? start) 0 start)
                   (if (default-object? end) (vector-length vector) end)))

-(define (vector-fill! vector value #!optional start)
+(define (vector-fill! vector value #!optional start end)
   (subvector-fill! vector
                   (if (default-object? start) 0 start)
                   (if (default-object? end) (vector-length vector) end)
@@ -314,4 +314,4 @@ USA.
                      (loop (fix:+ i 1))))
               #t)))))

Without this, I cannot build current git:

(echo '(with-working-directory-pathname "runtime"' && \
 echo '  (lambda () (load "runtime.cbf")))') \
| 'mit-scheme-x86-64' --batch-mode --band ./tools/compiler.com --eval '(begin  )'
;Loading "runtime.cbf"...
;  Compiling file: "./advice.bin" => "./advice.com"...
;Unbound variable: end
;To continue, call RESTART with an option number:
; (RESTART 3) => Specify a value to use instead of end.
; (RESTART 2) => Define end to a given value.
; (RESTART 1) => Return to read-eval-print level 1.


Greetings,
Peter