[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [MIT-Scheme-devel] Mis-compiled (bytevector)?
From: |
Matt Birkholz |
Subject: |
Re: [MIT-Scheme-devel] Mis-compiled (bytevector)? |
Date: |
Sun, 14 Jul 2019 12:21:47 -0700 |
User-agent: |
Evolution 3.32.1-2 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Thanks! You're right. I'm looking at the wrong branch.
Your git log command shows two commits with fixes for http-io.scm.
I'll cherry-pick both onto release-10.
On Sun, 2019-07-14 at 17:47 +0000, Taylor R Campbell wrote:
> > Date: Sun, 14 Jul 2019 09:49:20 -0700
> > From: Matt Birkholz <address@hidden>
> >
> > In 10.1.9 I create an HTTP request with body #f and write-http-
> > request
> > fails with 'The object "", passed as the first argument to
> > bytevector-length, is not the correct type.'
> >
> > I tracked this down to guarantee-headers&body. When body is #f it
> > returns the empty string instead of the empty bytevector. Pretty-
> > printing the procedure suggests '(bytevector)' was compiled to ""
> > instead of #u8().
>
> In 10.1.9, guarantee-headers&body is defined to return "", as you can
> see with:
>
> git show release-10.1.9:src/runtime/http-io.scm
>
> The change you made in November to make it return a bytevector was
> never back-ported to the release-10 branch, as you can see with:
>
> git log origin/release-10..origin/master -- src/runtime/http-io.scm
-----BEGIN PGP SIGNATURE-----
iQGzBAEBCgAdFiEELKqfot8xyi0bi8Ssp/sTamsYs6IFAl0rgMsACgkQp/sTamsY
s6LzBQwAnbH8dssGTQZAZHItsGoDGoqA89jkVoBseUAXrcjGeSpxb8RL4lA49Zwf
dUfyE6Dus9M6bqku+3SqSZlFSoHi1uKLPyH6LGRBe7IzK/KaBaFs7fJKiTkT6XmW
tcSxrVvbjjvHTy1FqNqr2AhsMEcL2q+LxncWaxGuwA5UgRh5tcbtx0f9SssckuHx
k/yDMxl2K2iNDnhvZksSrs+HsV0lsIlBjRYkQ7AHTIFuwVM+InKItpWUFTMyAliQ
hozuW+XD7Rcyt0ugUpTHr1EWyWmPUe7yfa0C8kVD1MieiFXl/90+WEdycuCodIwc
PsllffZjpWzKSJetwkqtvGrd8MRD7gDpIVro4K+xMZ7Xz4c0FoohxClP3sMBTdn6
VaGSjVw474idKRQvi3Wjo9ldq1r83DHpcbWhCL9Vta6K1PIySWnbbDrO5qtlwW6G
P+rrW+fVMe9OiCsvBYlrmOTajDAADTmQ2WzOM5S019+eQau/YYOFDUUEhw3Bj8k8
YySyQYEa
=AqP6
-----END PGP SIGNATURE-----