[Mldonkey-users] [patch #4909] let fail start on Windows 9x/ME

[z]

Follow-up Comment #1, patch #4909 (project mldonkey):

1. What is the point of disabling these OSs?  If it works for someone on
these OSs, why not let them use it?  A warning seems more appropriate, unless
you are absolutely sure that it does not work.

2. Matching arbitrary strings is always wrong in code when there is a
perfectly standard way to do what you are trying to do. (especially when some
strings have spaces after them and some don't). Use the windows API properly:
the dwPlatformId field of OSVERSIONINFO is all you need if you really want to
identifty non NT based systems.

3. Why do only windows users get this "used OS" line at startup?  Mldonkey
should try to be consistent on all platforms.

4. "unknown Operating System, please report Mldonkey Dev Team"

"Unknown operating system, please report to the MLDonkey development team at
http://...";

- it is better to give people a method to use to file reports when you
request that they send information.


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?func=detailitem&item_id=4909>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/