[Mldonkey-users] [patch #5599] ED2K: Support for file's sizes >4GB

[TripleM]

Follow-up Comment #16, patch #5599 (project mldonkey):

only a small reply, it should not in any way disturb a proper working of this
patch. you are partly wrong with your statment "the border is not
0xffffffffL". this is true for large file or not large file, but wrong for
using 64bit-opcodes, or 32bit-opcodes.
UploadClient.cpp line#510:
if (statpos > 0xFFFFFFFF || endpos > 0xFFFFFFFF){
  packet = new Packet(OP_SENDINGPART_I64,nPacketSize+32, OP_EMULEPROT,
bFromPF);
  md4cpy(&packet->pBuffer[0],GetUploadFileID());
  PokeUInt64(&packet->pBuffer[16], statpos);
  PokeUInt64(&packet->pBuffer[24], endpos);
  memfile.Read(&packet->pBuffer[32],nPacketSize);
  theStats.AddUpDataOverheadFileRequest(32);
}
else{
  packet = new Packet(OP_SENDINGPART,nPacketSize+24, OP_EDONKEYPROT,
bFromPF);
  md4cpy(&packet->pBuffer[0],GetUploadFileID());
  PokeUInt32(&packet->pBuffer[16], (uint32)statpos);
  PokeUInt32(&packet->pBuffer[20], (uint32)endpos);
  memfile.Read(&packet->pBuffer[24],nPacketSize);
  theStats.AddUpDataOverheadFileRequest(24);
}

but as i stated earlier, it should not matter, large-file-capable emules
accept 64bit-opcodes independent of bounderies. you could even use pure 64bit
for all files with largefilecapable emules, cause, as stated in opcodes.h, the
tag large_file_capable not only means this, but support for 64bit tags and
opcodes too. so i dont think, this behaviour will change in the future.

what could become a problem, is, if the emule devs decide to fully exhibit
this behaviour (comm with capable clients in 64bit-opcodes only), we have to
rework this patch. your changes to the patch (mainly merging the modules), as
appreciated they are, revoke mldonkey the ability to use the 64bit-opcodes for
smaller files.

sorry, that i mentioned it that late, but i dont found the time earlier to
look deeper into your changes, and to crosscheck that against emules
sources.


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?5599>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/